LowLevelDispatch no longer part of code generation

Author: Mpdreamz

src/CodeGeneration/ApiGenerator/ApiGenerator.cs

@@ -31,7 +31,6 @@ public static void Generate(string downloadBranch, params string[] folders)
 				{ GenerateRequests, "Requests" },
 				{ GenerateEnums, "Enums" },
 				{ GenerateRawClient, "Lowlevel client" },
-				{ GenerateRawDispatch, "Dispatch" },
 			};
 
 			using (var pbar = new ProgressBar(actions.Count, "Generating code", new ProgressBarOptions { BackgroundColor = ConsoleColor.DarkGray }))
@@ -181,14 +180,6 @@ private static void GenerateClientInterface(RestApiSpec model)
 			File.WriteAllText(targetFile, source);
 		}
 
-		private static void GenerateRawDispatch(RestApiSpec model)
-		{
-			var targetFile = CodeConfiguration.NestFolder + @"_Generated/_LowLevelDispatch.Generated.cs";
-			var source = DoRazor(nameof(GenerateRawDispatch), File.ReadAllText(CodeConfiguration.ViewFolder + @"_LowLevelDispatch.Generated.cshtml"),
-				model);
-			File.WriteAllText(targetFile, source);
-		}
-
 		private static void GenerateRawClient(RestApiSpec model)
 		{
 			var targetFile = CodeConfiguration.EsNetFolder + @"ElasticLowLevelClient.Generated.cs";

src/CodeGeneration/ApiGenerator/Views/_LowLevelDispatch.Generated.cshtml

@@ -26,12 +26,6 @@ public string Format(string format, object arg, IFormatProvider formatProvider)
 
 		public object GetFormat(Type formatType) => formatType == typeof(ICustomFormatter) ? this : null;
 
-		public string CreateEscapedString(object value)
-		{
-			var r = CreateString(value, _settings);
-			return r.IsNullOrEmpty() ? string.Empty : Uri.EscapeDataString(r);
-		}
-
 		public string CreateString(object value) => CreateString(value, _settings);
 
 		public static string CreateString(object value, IConnectionConfigurationValues settings)

src/Elasticsearch.Net/Serialization/ElasticsearchUrlFormatter.cs

@@ -56,6 +56,7 @@ protected RequestBase(Func<RouteValues, RouteValues> pathSelector)
 
 		IRequestParameters IRequest.RequestParametersInternal => RequestState.RequestParameters;
 
+		// TODO remove this is only used to make sure requests set typed_keys automatically, find better approach for this
 		protected virtual void Initialize() { }
 
 		protected TOut Q<TOut>(string name) => RequestState.RequestParameters.GetQueryStringValue<TOut>(name);
@@ -93,13 +94,8 @@ public abstract partial class RequestDescriptorBase<TDescriptor, TParameters, TI
 
 		protected RequestDescriptorBase(Func<RouteValues, RouteValues> pathSelector) : base(pathSelector) => _descriptor = (TDescriptor)this;
 
-		protected IRequestConfiguration RequestConfig => ((IRequestParameters)RequestState.RequestParameters).RequestConfiguration;
-
 		protected TInterface Self => _descriptor;
 
-		[Obsolete("Use the overload that accepts TValue")]
-		protected TDescriptor Assign(Action<TInterface> assign) => Fluent.Assign(_descriptor, assign);
-
 		protected TDescriptor Assign<TValue>(TValue value, Action<TInterface, TValue> assign) => Fluent.Assign(_descriptor, value, assign);
 
 		protected TDescriptor AssignParam(Action<TParameters> assigner)

src/Nest/CommonAbstractions/Request/RequestBase.cs

@@ -27,7 +27,6 @@ public ElasticClient(ITransport<IConnectionSettingsValues> transport)
 
 			Transport = transport;
 			LowLevel = new ElasticLowLevelClient(Transport);
-			LowLevelDispatch = new LowLevelDispatch(LowLevel);
 		}
 
 		public IConnectionSettingsValues ConnectionSettings => Transport.Settings;
@@ -38,8 +37,6 @@ public ElasticClient(ITransport<IConnectionSettingsValues> transport)
 
 		public IElasticsearchSerializer SourceSerializer => Transport.Settings.SourceSerializer;
 
-		private LowLevelDispatch LowLevelDispatch { get; }
-
 		private ITransport<IConnectionSettingsValues> Transport { get; }
 
 		internal TResponse DoRequest<TRequest, TResponse>(TRequest p, IRequestParameters parameters, Action<IRequestConfiguration> forceConfiguration = null)