Serialize Distance and Percentiles aggregate using an invariant locale (#4042)

* Serialize Distance to JSON using invariant culture
* Use invariant culture for double.Parse in PercentileItem
* Added test case and fix for similar issue

Closes #4044
Closes #4041

(cherry picked from commit 5839da0)
(cherry picked from commit 9fe3e47)

Author: rickardp

src/Nest/Aggregations/AggregateFormatter.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
+using System.Globalization;
 using System.Linq;
 using System.Reflection;
 using Elasticsearch.Net;
@@ -328,7 +329,7 @@ private IAggregate GetPercentilesAggregate(ref JsonReader reader, IReadOnlyDicti
 
 					metric.Items.Add(new PercentileItem
 					{
-						Percentile = double.Parse(propertyName),
+						Percentile = double.Parse(propertyName, CultureInfo.InvariantCulture),
 						Value = reader.ReadNullableDouble()
 					});
 				}

src/Nest/CommonOptions/Geo/Distance.cs

@@ -66,6 +66,6 @@ public Distance(string distanceUnit)
 
 		public static implicit operator Distance(string distanceUnit) => new Distance(distanceUnit);
 
-		public override string ToString() => $"{Precision}{Unit.GetStringValue()}";
+		public override string ToString() => Precision.ToString(CultureInfo.InvariantCulture) + Unit.GetStringValue();
 	}
 }

src/Tests/Tests.Reproduce/GithubIssue4041.cs

@@ -0,0 +1,23 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Elastic.Xunit.XunitPlumbing;
+using Nest;
+using static Tests.Core.Serialization.SerializationTestHelper;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue4041
+	{
+		[U]
+		[UseCulture("sv-SE")]
+		public void DistanceSerializesWithInvariantCulture()
+		{
+			const string distanceString = "2.5m";
+			Distance distance = distanceString;
+
+			Expect(distanceString)
+				.WhenSerializing(distance);
+		}
+	}
+}

src/Tests/Tests.Reproduce/GithubIssue4044.cs

@@ -0,0 +1,31 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Elastic.Xunit.XunitPlumbing;
+using FluentAssertions;
+using Nest;
+using static Tests.Core.Serialization.SerializationTestHelper;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue4044
+	{
+		[U]
+		[UseCulture("sv-SE")]
+		public void PercentilesAggregateSerializesWithInvariantCulture()
+		{
+			const string percentilesString = @"{
+				""test_percentiles#pp"": {
+					""values"": {
+						""42.42"": 42.42
+					}
+				}
+			}";
+
+			Expect(percentilesString).NoRoundTrip().DeserializesTo<AggregateDictionary>((s, val) =>
+			{
+				val.Count.Should().Be(1);
+			});
+		}
+	}
+}

src/Tests/Tests/Tests.csproj

@@ -23,6 +23,7 @@
     <PackageReference Include="System.Diagnostics.FileVersionInfo" Version="4.3.0" />
     <PackageReference Include="SemanticVersioning" Version="0.8.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
+    <PackageReference Include="xunit.core" Version="2.3.1" />
     <PackageReference Include="xunit.extensibility.execution" Version="2.3.1" />
     <PackageReference Include="Ben.Demystifier" Version="0.1.4" />
   </ItemGroup>