fix some build scripts warnings

(cherry picked from commit 0c10798)

Author: Mpdreamz

build/scripts/Building.fs

@@ -6,7 +6,6 @@ namespace Scripts
 
 open System.IO
 
-open Paths
 open Tooling
 open Versioning
 open Fake.Core
@@ -19,7 +18,7 @@ open System.IO.Compression
 
 module Build =
 
-    let Restore() = DotNet.Exec ["restore"; Solution; ] |> ignore
+    let Restore() = DotNet.Exec ["restore"; Paths.Solution; ] |> ignore
 
     let Compile _ version = 
         let props = 
@@ -32,7 +31,7 @@ module Build =
             |> String.concat ";"
             |> sprintf "/property:%s"
 
-        DotNet.Exec ["build"; Solution; "-c"; "Release"; props] |> ignore
+        DotNet.Exec ["build"; Paths.Solution; "-c"; "Release"; props] |> ignore
 
     let Pack version = 
         let props = 
@@ -45,19 +44,19 @@ module Build =
             |> String.concat ";"
             |> sprintf "/p:%s"
 
-        DotNet.Exec ["pack"; Solution; "-c"; "Release"; "-o"; Paths.NugetOutput ; props] |> ignore
+        DotNet.Exec ["pack"; Paths.Solution; "-c"; "Release"; "-o"; Paths.NugetOutput ; props] |> ignore
 
     let Clean isCanary =
         printfn "Cleaning known output folders"
         Shell.cleanDir Paths.BuildOutput
         if isCanary then 
-            DotNet.Exec ["clean"; Solution; "-c"; "Release"; "-v"; "q"] |> ignore 
+            DotNet.Exec ["clean"; Paths.Solution; "-c"; "Release"; "-v"; "q"] |> ignore 
 
     let private keyFile = Paths.Keys "keypair.snk"
     let private tmp = "build/output/_packages/tmp" 
 
     let VersionedPack version =
-        let packages = Versioning.BuiltArtifacts version
+        let packages = BuiltArtifacts version
         let currentMajorVersion = version.Full.Major
 
         let newId nugetId = sprintf "%s.v%i" nugetId currentMajorVersion

build/scripts/Commandline.fs

@@ -112,7 +112,7 @@ Execution hints can be provided anywhere on the command line
 
     let notWindows =
         RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || 
-        RuntimeInformation.IsOSPlatform(System.Runtime.InteropServices.OSPlatform.OSX)
+        RuntimeInformation.IsOSPlatform(OSPlatform.OSX)
 
     let private buildingOnAzurePipeline = Environment.environVarAsBool "TF_BUILD"
 

build/scripts/Targets.fs

@@ -7,10 +7,7 @@ namespace Scripts
 open System
 open System.IO
 
-open Build
-open Commandline
 open Bullseye
-open Octokit
 open ProcNet
 open Fake.Core
 
@@ -67,7 +64,7 @@ module Main =
 
         target "version" <| fun _ -> printfn "Artifacts Version: %O" artifactsVersion
 
-        target "restore" Restore
+        target "restore" Build.Restore
 
         target "full-build" <| fun _ -> Build.Compile parsed artifactsVersion
 
@@ -91,7 +88,7 @@ module Main =
 
         //RELEASE
         command "release" releaseChain <| fun _ ->
-            let outputPath = match parsed.CommandArguments with | SetVersion c -> c.OutputLocation | _ -> None
+            let outputPath = match parsed.CommandArguments with | Commandline.SetVersion c -> c.OutputLocation | _ -> None
             match outputPath with
             | None -> printfn "Finished Release Build %O, artifacts available at: %s" artifactsVersion Paths.BuildOutput
             | Some path ->

build/scripts/Testing.fs

@@ -41,7 +41,7 @@ module Tests =
         let runSettings =
             // force the logger section to be cleared so that azure devops can work its magic.
             // relies heavily on the original console logger
-            let prefix = if Commandline.runningOnAzureDevops then ".ci" else ""
+            let prefix = if runningOnAzureDevops then ".ci" else ""
             sprintf "tests/%s.runsettings" prefix
 
         Directory.CreateDirectory Paths.BuildOutput |> ignore

build/scripts/Tooling.fs

@@ -10,7 +10,7 @@ open ProcNet.Std
 
 module Tooling = 
 
-    type ExecResult = { ExitCode: int; Output: Std.LineOut seq;}
+    type ExecResult = { ExitCode: int; Output: LineOut seq;}
 
     let private defaultTimeout = TimeSpan.FromMinutes(5.)
 

build/scripts/Versioning.fs

@@ -5,10 +5,7 @@
 namespace Scripts
 
 open System
-open System.Reflection
-open System.Diagnostics
 open System.IO
-open Commandline
 open Fake.Core
 open Fake.IO
 open Fake.IO.Globbing.Operators
@@ -59,14 +56,14 @@ module Versioning =
                 doc_current = doc_current
                 doc_branch = doc_branch
         }
-        File.WriteAllText("global.json", JsonConvert.SerializeObject(newGlobalJson, Newtonsoft.Json.Formatting.Indented))
+        File.WriteAllText("global.json", JsonConvert.SerializeObject(newGlobalJson, Formatting.Indented))
         printfn "Written (%s) to global.json as the current version will use this version from now on as current in the build" (version.ToString()) 
 
     let GlobalJsonVersion = parse <| globalJson().version
 
     let private getVersion (args:Commandline.PassedArguments) =
         match (args.Target, args.CommandArguments) with
-        | (_, SetVersion v) ->
+        | (_, Commandline.SetVersion v) ->
             match v.Version with
             | v when String.IsNullOrEmpty v -> None
             | v -> Some <| parse v