Skip to content

Commit 2d6d3d2

Browse files
authored
Remove _source_include and _source_exclude from generated (#3726)
Fixes #3682
1 parent 2156ea1 commit 2d6d3d2

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

src/CodeGeneration/ApiGenerator/Overrides/GlobalOverrides.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ public class GlobalOverrides : EndpointOverridesBase
2828
{ "_source", "source_enabled" },
2929
{ "_source_includes", "source_include" },
3030
{ "_source_excludes", "source_exclude" },
31-
{ "_source_include", "source_include" },
32-
{ "_source_exclude", "source_exclude" },
3331
{ "rest_total_hits_as_int", "total_hits_as_integer" },
3432
{ "docvalue_fields", "doc_value_fields" },
3533
{ "q", "query_on_query_string" },
@@ -56,6 +54,7 @@ public class GlobalOverrides : EndpointOverridesBase
5654
"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method
5755
"ttl",
5856
"timestamp",
57+
"_source_include", "_source_exclude" // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in
5958
};
6059
}
6160
}

src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -855,9 +855,9 @@ public class GetRequestParameters : RequestParameters<GetRequestParameters>
855855
///<summary>True or false to return the _source field or not, or a list of fields to return</summary>
856856
public bool? SourceEnabled { get => Q<bool?>("_source"); set => Q("_source", value); }
857857
///<summary>A list of fields to exclude from the returned _source field</summary>
858-
public string[] SourceExclude { get => Q<string[]>("_source_exclude"); set => Q("_source_exclude", value); }
858+
public string[] SourceExclude { get => Q<string[]>("_source_excludes"); set => Q("_source_excludes", value); }
859859
///<summary>A list of fields to extract and return from the _source field</summary>
860-
public string[] SourceInclude { get => Q<string[]>("_source_include"); set => Q("_source_include", value); }
860+
public string[] SourceInclude { get => Q<string[]>("_source_includes"); set => Q("_source_includes", value); }
861861
///<summary>Explicit version number for concurrency control</summary>
862862
public long? Version { get => Q<long?>("version"); set => Q("version", value); }
863863
///<summary>Specific version type</summary>

src/Nest/_Generated/_Descriptors.generated.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,14 +1471,14 @@ internal GetDescriptor() : base(){}
14711471
///<summary>Whether the _source should be included in the response.</summary>
14721472
public GetDescriptor<TDocument> SourceEnabled(bool? sourceEnabled = true) => Qs("_source", sourceEnabled);
14731473
///<summary>A list of fields to exclude from the returned _source field</summary>
1474-
public GetDescriptor<TDocument> SourceExclude(Fields sourceExclude) => Qs("_source_exclude", sourceExclude);
1474+
public GetDescriptor<TDocument> SourceExclude(Fields sourceExclude) => Qs("_source_excludes", sourceExclude);
14751475
///<summary>A list of fields to exclude from the returned _source field</summary>
1476-
public GetDescriptor<TDocument> SourceExclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_exclude", fields?.Select(e=>(Field)e));
1476+
public GetDescriptor<TDocument> SourceExclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_excludes", fields?.Select(e=>(Field)e));
14771477

14781478
///<summary>A list of fields to extract and return from the _source field</summary>
1479-
public GetDescriptor<TDocument> SourceInclude(Fields sourceInclude) => Qs("_source_include", sourceInclude);
1479+
public GetDescriptor<TDocument> SourceInclude(Fields sourceInclude) => Qs("_source_includes", sourceInclude);
14801480
///<summary>A list of fields to extract and return from the _source field</summary>
1481-
public GetDescriptor<TDocument> SourceInclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_include", fields?.Select(e=>(Field)e));
1481+
public GetDescriptor<TDocument> SourceInclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_includes", fields?.Select(e=>(Field)e));
14821482

14831483
///<summary>Explicit version number for concurrency control</summary>
14841484
public GetDescriptor<TDocument> Version(long? version) => Qs("version", version);

src/Nest/_Generated/_Requests.generated.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3915,9 +3915,9 @@ internal GetRequest() : base(){}
39153915
///<summary>Whether the _source should be included in the response.</summary>
39163916
public bool? SourceEnabled { get => Q<bool?>("_source"); set => Q("_source", value); }
39173917
///<summary>A list of fields to exclude from the returned _source field</summary>
3918-
public Fields SourceExclude { get => Q<Fields>("_source_exclude"); set => Q("_source_exclude", value); }
3918+
public Fields SourceExclude { get => Q<Fields>("_source_excludes"); set => Q("_source_excludes", value); }
39193919
///<summary>A list of fields to extract and return from the _source field</summary>
3920-
public Fields SourceInclude { get => Q<Fields>("_source_include"); set => Q("_source_include", value); }
3920+
public Fields SourceInclude { get => Q<Fields>("_source_includes"); set => Q("_source_includes", value); }
39213921
///<summary>Explicit version number for concurrency control</summary>
39223922
public long? Version { get => Q<long?>("version"); set => Q("version", value); }
39233923
///<summary>Specific version type</summary>

0 commit comments

Comments
 (0)