remove try catch around assert, obfuscates stacktrace. Added more debug information on crudtestbase isvalid assertations

Author: Mpdreamz

src/Tests/Framework/CrudTestBase.cs

@@ -110,16 +110,16 @@ protected async Task AssertOnAllResponses<TResponse>(LazyResponses responses, Ac
 				var response = kv.Value as TResponse;
 				if (response == null)
 					throw new Exception($"{kv.Value.GetType()} is not expected response type {typeof(TResponse)}");
-				try
-				{
+				//try
+				//{
 					assert(response);
-				}
+				//}
 #pragma warning disable 7095
-				catch (Exception ex) when (false)
+				//catch (Exception ex) when (false)
 #pragma warning restore 7095
-				{
-					throw new Exception($"asserting over the response from: {kv.Key} failed: {ex.Message}", ex);
-				}
+				//{
+				//	throw new Exception($"asserting over the response from: {kv.Key} failed: {ex.Message}", ex);
+				//}
 			}
 		}
 
@@ -147,19 +147,24 @@ protected async Task AssertOnGetAfterDelete(Action<TReadResponse> assert)
 		protected virtual void ExpectAfterCreate(TReadResponse response) { }
 		protected virtual void ExpectAfterUpdate(TReadResponse response) { }
 
-		[I] protected virtual async Task CreateCallIsValid() => await this.AssertOnCreate(r => r.IsValid.Should().Be(true));
+		[I] protected virtual async Task CreateCallIsValid() =>
+			await this.AssertOnCreate(r => r.IsValid.Should().Be(true, "{0}", r.DebugInformation));
 		[I] protected virtual async Task GetAfterCreateIsValid() => await this.AssertOnGetAfterCreate(r => {
-			r.IsValid.Should().Be(true);
+			r.IsValid.Should().Be(true, "{0}", r.DebugInformation);
 			ExpectAfterCreate(r);
 		});
 
-		[I] protected virtual async Task UpdateCallIsValid() => await this.AssertOnUpdate(r => r.IsValid.Should().Be(true));
+		[I] protected virtual async Task UpdateCallIsValid()
+				=> await this.AssertOnUpdate(r => r.IsValid.Should().Be(true, "{0}", r.DebugInformation));
+
 		[I] protected virtual async Task GetAfterUpdateIsValid() => await this.AssertOnGetAfterUpdate(r => {
-			r.IsValid.Should().Be(true);
+			r.IsValid.Should().Be(true, "{0}", r.DebugInformation);
 			ExpectAfterUpdate(r);
 		});
 
-		[I] protected virtual async Task DeleteCallIsValid() => await this.AssertOnDelete(r => r.IsValid.Should().Be(true));
-		[I] protected virtual async Task GetAfterDeleteIsValid() => await this.AssertOnGetAfterDelete(r => r.IsValid.Should().Be(false));
+		[I] protected virtual async Task DeleteCallIsValid() =>
+			await this.AssertOnDelete(r => r.IsValid.Should().Be(true, "{0}", r.DebugInformation));
+		[I] protected virtual async Task GetAfterDeleteIsValid() => await
+			this.AssertOnGetAfterDelete(r => r.IsValid.Should().Be(false, "{0}", r.DebugInformation));
 	}
 }