Fix stack overflow in reindex observable

Author: gmarz

src/Nest/Domain/Observers/ReindexObservable.cs

@@ -53,16 +53,16 @@ private void Reindex(IObserver<IReindexResponse<T>> observer)
 				throw new ReindexException(createIndexResponse.ConnectionStatus);
 
 			var page = 0;
-			Func<SearchDescriptor<T>, SearchDescriptor<T>> searchDescriptor = s => s.Index(fromIndex);
+			var searchDescriptor = new SearchDescriptor<T>().Index(fromIndex);
 
 			if (allTypes)
-				searchDescriptor = s => searchDescriptor(s).AllTypes();
+				searchDescriptor.AllTypes();
 			else
-				searchDescriptor = s => searchDescriptor(s).Type<T>();
+				searchDescriptor.Type<T>();
 
 
 			var searchResult = this.CurrentClient.Search<T>(
-				s => searchDescriptor(s)
+				s => searchDescriptor
 					.From(0)
 					.Size(size)
 					.Query(this._reindexDescriptor._QuerySelector ?? (q => q.MatchAll()))

src/Nest/Domain/Observers/ReindexObserver.cs

@@ -11,6 +11,17 @@ public ReindexObserver(
 			: base(onNext, onError, completed)
 		{
 		}
+	}
+
+	public class ReindexObserver : ReindexObserver<IDocument>
+	{
 
+		public ReindexObserver(
+			Action<IReindexResponse<IDocument>> onNext = null,
+			Action<Exception> onError = null,
+			Action completed = null)
+			: base(onNext, onError, completed)
+		{
+		}
 	}
 }

src/Tests/Nest.Tests.Integration/Index/ReindexTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using NUnit.Framework;
+using Nest.Tests.MockData.Domain;
 
 
 namespace Nest.Tests.Integration.Index
@@ -13,11 +14,11 @@ public class ReindexTests : IntegrationTests
 		public void ReindexMinimal()
 		{
 			var toIndex = ElasticsearchConfiguration.NewUniqueIndexName();
-			var observable = this.Client.Reindex<object>(r => r
+			var observable = this.Client.Reindex(r => r
 				.FromIndex(ElasticsearchConfiguration.DefaultIndex)
 				.ToIndex(toIndex)
 			);
-			var observer = new ReindexObserver<object>(
+			var observer = new ReindexObserver(
 				onError: (e) => Assert.Fail(e.Message),
 				completed: () =>
 				{