Skip to content

Commit 19a15a3

Browse files
committed
Fix #1674: Types is optional and shouldn't cause conditionless behavior when not specified
1 parent 2b39ce3 commit 19a15a3

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/Nest/QueryDsl/TermLevel/Ids/IdsQuery.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class IdsQuery : QueryBase, IIdsQuery
2222
public IEnumerable<Id> Values { get; set; }
2323

2424
internal override void WrapInContainer(IQueryContainer c) => c.Ids = this;
25-
internal static bool IsConditionless(IIdsQuery q) => q.Types == null || !q.Values.HasAny();
25+
internal static bool IsConditionless(IIdsQuery q) => !q.Values.HasAny();
2626
}
2727

2828
public class IdsQueryDescriptor

src/Tests/QueryDsl/TermLevel/Ids/IdsQueryUsageTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
4141

4242
protected override ConditionlessWhen ConditionlessWhen => new ConditionlessWhen<IIdsQuery>(a => a.Ids)
4343
{
44-
q => q.Types = null,
4544
q => q.Values = null,
4645
q => q.Values = Enumerable.Empty<Id>()
4746
};

0 commit comments

Comments
 (0)