added tests for hard exceptions in IConnection async methods

Author: Mpdreamz

src/Elasticsearch.Net/Connection/Transport.cs

@@ -515,18 +515,29 @@ private Task<ElasticsearchResponse<Stream>> CallIntoConnectionAsync<T>(Transport
 			var uri = requestState.CreatePathOnCurrentNode();
 			var postData = requestState.PostData;
 			var requestConfiguration = requestState.RequestConfiguration;
-			switch (requestState.Method.ToLowerInvariant())
+			var method = requestState.Method.ToLowerInvariant();
+			try
 			{
-				case "head": return this.Connection.Head(uri, requestConfiguration);
-				case "get": return this.Connection.Get(uri, requestConfiguration);
-				case "post": return this.Connection.Post(uri, postData, requestConfiguration);
-				case "put": return this.Connection.Put(uri, postData, requestConfiguration);
-				case "delete":
-					return postData == null || postData.Length == 0
-						? this.Connection.Delete(uri, requestConfiguration)
-						: this.Connection.Delete(uri, postData, requestConfiguration);
+				switch (method)
+				{
+					case "head": return this.Connection.Head(uri, requestConfiguration);
+					case "get": return this.Connection.Get(uri, requestConfiguration);
+					case "post": return this.Connection.Post(uri, postData, requestConfiguration);
+					case "put": return this.Connection.Put(uri, postData, requestConfiguration);
+					case "delete":
+						return postData == null || postData.Length == 0
+							? this.Connection.Delete(uri, requestConfiguration)
+							: this.Connection.Delete(uri, postData, requestConfiguration);
+					default:
+						throw new Exception("Unknown HTTP method " + requestState.Method);
+				}
+			}
+			catch (Exception e)
+			{
+				var tcs = new TaskCompletionSource<ElasticsearchResponse<Stream>>();
+				tcs.SetException(e);
+				return tcs.Task;
 			}
-			throw new Exception("Unknown HTTP method " + requestState.Method);
 		}
 
 		private Task<MemoryStream> Iterate(IEnumerable<Task> asyncIterator, MemoryStream memoryStream)

src/Tests/Elasticsearch.Net.Tests.Unit/Connection/RetryTests.cs

@@ -41,6 +41,27 @@ public void ThrowsMaxRetryException_AndRetriesTheSpecifiedTimes()
 
 			}
 		}
+		
+		[Test]
+		public void ThrowsMaxRetryException_AndRetriesTheSpecifiedTimes_HardIConnectionException_Async()
+		{
+			using (var fake = new AutoFake(callsDoNothing: true))
+			{
+				fake.Provide<IConnectionConfigurationValues>(_connectionConfig);
+				FakeCalls.ProvideDefaultTransport(fake);
+				var getCall = FakeCalls.GetCall(fake);
+
+				//return a started task that throws
+				getCall.Throws<Exception>();
+
+				var client = fake.Resolve<ElasticsearchClient>();
+
+				client.Settings.MaxRetries.Should().Be(_retries);
+
+				Assert.Throws<MaxRetryException>(async () => await client.InfoAsync());
+				getCall.MustHaveHappened(Repeated.Exactly.Times(_retries + 1));
+			}
+		}
 
 		[Test]
 		public void ThrowsMaxRetryException_AndRetriesTheSpecifiedTimes_Async()