do not snoop ApiCall from response but rely on it being passed to CreateClientException, it could come from a nested exception

Author: Mpdreamz

src/Elasticsearch.Net/Transport/Pipeline/IRequestPipeline.cs

@@ -53,7 +53,7 @@ void BadResponse<TResponse>(ref TResponse response, IApiCallDetails callDetails,
 
 		void AuditCancellationRequested();
 
-		ElasticsearchClientException CreateClientException<TResponse>(TResponse response, RequestData data, List<PipelineException> seenExceptions)
+		ElasticsearchClientException CreateClientException<TResponse>(TResponse response, IApiCallDetails callDetails, RequestData data, List<PipelineException> seenExceptions)
 			where TResponse : class, IElasticsearchResponse, new();
 	}
 }

src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs

@@ -482,15 +482,16 @@ public void BadResponse<TResponse>(ref TResponse response, IApiCallDetails callD
 			response.ApiCall.AuditTrail = this.AuditTrail;
 		}
 
-		public ElasticsearchClientException CreateClientException<TResponse>(TResponse response, RequestData data, List<PipelineException> pipelineExceptions)
+		public ElasticsearchClientException CreateClientException<TResponse>(
+			TResponse response, IApiCallDetails callDetails, RequestData data, List<PipelineException> pipelineExceptions
+		)
 			where TResponse : class, IElasticsearchResponse, new()
 		{
-			var callDetails = response.ApiCall;
 			if (callDetails.Success) return null;
 			var innerException = pipelineExceptions.HasAny() ? new AggregateException(pipelineExceptions) : callDetails?.OriginalException;
 
 			var exceptionMessage = innerException?.Message ?? $"Request failed to execute";
-			if (response.TryGetServerErrorReason(out var reason))
+			if (response != null && response.TryGetServerErrorReason(out var reason))
 				exceptionMessage += $". ServerError: {reason}";
 
 			var pipelineFailure = data.OnFailurePipelineFailure;

src/Elasticsearch.Net/Transport/Transport.cs

@@ -171,7 +171,7 @@ private TResponse FinalizeResponse<TResponse>(RequestData requestData, IRequestP
 				pipeline.ThrowNoNodesAttempted(requestData, seenExceptions);
 
 			var callDetails = GetMostRecentCallDetails(response, seenExceptions);
-			var clientException = pipeline.CreateClientException(response, requestData, seenExceptions);
+			var clientException = pipeline.CreateClientException(response, callDetails, requestData, seenExceptions);
 
 			if (response?.ApiCall == null)
 				pipeline.BadResponse(ref response, callDetails, requestData, clientException);