fix: correct new release process (#231)

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>

Author: amannocci

.github/workflows/pre-post-release.yml

@@ -15,7 +15,7 @@ on:
         required: true
       phase:
         description: 'Pre or post release phase'
-        type: string #valid values are 'pre' or 'post'
+        type: string # valid values are 'pre' or 'post'
         required: true
 
 env:
@@ -82,7 +82,7 @@ jobs:
         if: inputs.phase == 'post'
         uses: ./.github/workflows/maven-goal
         with:
-          command: ./mvnw -V versions:set -DprocessAllModules=true -DgenerateBackupPoms=false -nextSnapshot=true
+          command: ./mvnw -V versions:set -DprocessAllModules=true -DgenerateBackupPoms=false -DnextSnapshot=true
 
       - name: Push the ${{ inputs.phase }} release branch
         run: |

.github/workflows/pre-release.yml

@@ -12,13 +12,18 @@ on:
         description: 'The version to release (e.g. 1.2.3). This workflow will automatically perform the required version bumps'
         required: true
 
+permissions:
+  contents: read
+
 concurrency:
   group: ${{ github.workflow }}
 
 jobs:
   pre-release:
     name: "Bump versions and create PR"
     uses: ./.github/workflows/pre-post-release.yml
+    permissions:
+      contents: write
     with:
       ref: ${{ inputs.ref }}
       version: ${{ inputs.version }}

.github/workflows/release.yml

@@ -19,10 +19,12 @@ on:
 permissions:
   contents: read
 
-
 concurrency:
   group: ${{ github.workflow }}
 
+env:
+  RELEASE_VERSION: ${{ inputs.version }}
+
 jobs:
   validate-tag:
     runs-on: ubuntu-latest
@@ -88,7 +90,7 @@ jobs:
     needs:
       - release
     uses: ./.github/workflows/pre-post-release.yml
-    if: inputs.dry_run == 'false'
+    if: inputs.dry_run == false
     with:
       ref: ${{ inputs.ref }}
       version: ${{ inputs.version }}