-
Notifications
You must be signed in to change notification settings - Fork 32
Add docker layer caching for docker builds #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Mpdreamz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me mind giving the PR description as to why these changes are necessary?
I've read https://docs.docker.com/build/ci/github-actions/cache/#github-cache and understand what it does not super clear on all the benefits. Is this to speed up the build? A lot of time is simply the AOT publish maybe?
The default max cache size is 10GB so no qualms there.
It looks like the caching made the build even slower. 😅 The main reason why I created this PR was because I saw the |
| dnf install -y npm git clang tar findutils && \ | ||
| dnf clean all | ||
|
|
||
| # Install .NET SDK based on global.json version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave in the comment that this might be temporary:
No description provided.