fix: rm non-eic package versions now in upstream #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes 8 Python package override files that were previously added to provide specific versions needed for Rucio integration but are no longer necessary as these versions are now available in upstream Spack. This change eliminates technical debt by removing redundant package definitions.
- Removes custom Python package versions (py-urllib3, py-rucio-clients, py-rpds-py, py-rich, py-python-swiftclient, py-packaging, py-jsonschema, py-argcomplete)
- Dependencies in remaining packages (py-eic-rucio-policy-package, pyrobird) will now resolve to upstream Spack versions
- Simplifies repository maintenance by reducing custom package overrides
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/py-urllib3/package.py | Removes override that added version 2.3.0 and Python 3.8+/3.9+ dependencies |
| packages/py-rucio-clients/package.py | Removes override that added version 37.3.0 and multiple dependency version constraints |
| packages/py-rpds-py/package.py | Removes override with Rust 1.76+ dependency and custom runtime dependency hack |
| packages/py-rich/package.py | Removes override that added version 13.9.4 |
| packages/py-python-swiftclient/package.py | Removes override with custom URL versioning logic and version 4.7.0 |
| packages/py-packaging/package.py | Removes override that added version 24.2 |
| packages/py-jsonschema/package.py | Removes override that added version 4.23.0 |
| packages/py-argcomplete/package.py | Removes override that added version 3.5.3 and multiple build dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
In the transition of v1 to v2 spack package repository, we copied over a few python packages to add versions to them necessary for our rucio integration. These are not necessary anymore (and probably weren't at the time since we figured out soon after that we could cherry-pick against changed paths).
This PR removes those technical debt packages.
What kind of change does this PR introduce?