jana2: add podio dependency upper limit version due to operator-> on collections #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
changed the title
veprbl
approved these changes
Nov 29, 2025
wdconinc
force-pushed
the
wdconinc-patch-4
branch
from
fe8419b to
ceeaa93
Compare
Copilot finished reviewing on behalf of
wdconinc
November 29, 2025 14:51
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a version constraint to prevent incompatible combinations of JANA2 and podio packages. Specifically, it ensures that JANA2 versions 2.4.2 and earlier, which use the operator-> on podio collections, are not built with podio versions above 1.4 where this operator was removed.
- Adds upper bound constraint
podio@:1.4for JANA2 versions@:2.4.2when built with +podio variant - Ensures compatibility after podio removed
operator->support in versions > 1.4 - Works in conjunction with existing constraint that limits podio to 0.17.3 for even older JANA2 versions (@:2.1.2)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
In AIDASoft/podio#812 support for operator-> on podio collections was removed. JANA2 fixed this in 2.4.3.