chore: acts-44.3.0 #80
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ACTS (A Common Tracking Software) package from version 39.2.0 to 44.3.0 and the Eigen library from version 3.4.0 to 3.4.1. The update includes cherry-picking multiple commits from the upstream spack/spack-packages repository that add new ACTS versions (44.0.0, 44.0.1, 44.1.0, 44.2.0, and 44.3.0), deprecate older ACTS versions, add new Eigen versions, and introduce various dependency-related improvements.
However, the PR has critical issues: two eigen-related cherry-pick commits are missing from spack-packages.sh, and the eigen version in packages.yaml was not updated despite being shown in the diff.
Key Changes
- Update ACTS from version 39.2.0 to 44.3.0 with associated cherry-picked commits
- Intended update of Eigen from 3.4.0 to 3.4.1 (but not applied in packages.yaml)
- Removal of superseded cherry-pick commit (387d9a5213c) that was replaced by a newer commit
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spack-packages.sh | Adds 11 new cherry-pick commit hashes (but only 9 present) for ACTS and Eigen updates, removes 1 superseded commit, updates descriptions; missing 2 eigen-related commits |
| spack-environment/packages.yaml | Updates ACTS version to 44.3.0; eigen version update to 3.4.1 not applied despite being in the diff |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Briefly, what does this PR introduce?
This PR updates
actsto 44.3.0.