Skip to content

fix: move units from comments to the podio field for it #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: move units from comments to the podio field for it #136

wants to merge 2 commits into from
+288 −270

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 28, 2025

Briefly, what does this PR introduce?

This PR cleans up the edm4eic yaml file a bit:

  • move the units from the comments to the field for it in the datamodel syntax,
  • use yaml multiline blocks for declarations instead of ugly strings,
  • align the variables and comments a bit better.

@wdconinc wdconinc requested a review from a team as a code owner November 28, 2025 20:26
veprbl
veprbl reviewed Nov 29, 2025
View reviewed changes
@wdconinc wdconinc enabled auto-merge (squash) November 29, 2025 15:13
@wdconinc wdconinc disabled auto-merge November 29, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wdconinc @veprbl