Skip to content

Commit 9394ac1

Browse files
author
steve
committed
Fixed Github issue #5 to properly handle the 'dnstap-output' variants
Added a test file to exercise all variants of 'dnstap-output'
1 parent 2e3e0eb commit 9394ac1

File tree

2 files changed

+68
-29
lines changed

2 files changed

+68
-29
lines changed

syntax/bind-named.vim

Lines changed: 35 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2336,36 +2336,46 @@ syn keyword namedO_DnstapOutputSuffixType contained
23362336
\ increment
23372337
\ timestamp
23382338
\ skipwhite skipnl skipempty
2339-
\ nextgroup=namedSemicolon
2339+
\ nextgroup=namedSemicolon,
2340+
\ namedO_DnstapOutputSize,
2341+
\ namedO_DnstapOutputVersions
23402342

23412343
hi link namedO_DnstapOutputSizeValue namedHL_Number
23422344
syn match namedO_DnstapOutputSizeValue contained /[0-9]\{1,10}/
23432345
\ skipwhite skipnl skipempty
2344-
\ nextgroup=namedSemicolon
2346+
\ nextgroup=namedSemicolon,
2347+
\ namedO_DnstapOutputSuffix,
2348+
\ namedO_DnstapOutputVersions
23452349

23462350
hi link namedO_DnstapOutputSizeBuiltin namedHL_Builtin
23472351
syn keyword namedO_DnstapOutputSizeBuiltin contained
23482352
\ unlimited
23492353
\ skipwhite skipnl skipempty
2350-
\ nextgroup=namedSemicolon
2354+
\ nextgroup=namedSemicolon,
2355+
\ namedO_DnstapOutputSuffix,
2356+
\ namedO_DnstapOutputVersions
23512357

2352-
hi link namedO_DnstapOutputVersionBuiltin namedHL_Builtin
2353-
syn keyword namedO_DnstapOutputVersionBuiltin contained
2358+
hi link namedO_DnstapOutputVersionsBuiltin namedHL_Builtin
2359+
syn keyword namedO_DnstapOutputVersionsBuiltin contained
23542360
\ unlimited
23552361
\ skipwhite skipnl skipempty
2356-
\ nextgroup=namedSemicolon
2362+
\ nextgroup=namedSemicolon,
2363+
\ namedO_DnstapOutputSuffix,
2364+
\ namedO_DnstapOutputSize,
23572365

2358-
hi link namedO_DnstapOutputVersionNumber namedHL_Number
2359-
syn match namedO_DnstapOutputVersionNumber contained /\d\+/
2366+
hi link namedO_DnstapOutputVersionsNumber namedHL_Number
2367+
syn match namedO_DnstapOutputVersionsNumber contained /\d\+/
23602368
\ skipwhite skipnl skipempty
2361-
\ nextgroup=namedSemicolon
2369+
\ nextgroup=namedSemicolon,
2370+
\ namedO_DnstapOutputSuffix,
2371+
\ namedO_DnstapOutputSize
23622372

2363-
hi link namedO_DnstapOutputVersion namedHL_Clause
2364-
syn keyword namedO_DnstapOutputVersion contained version
2373+
hi link namedO_DnstapOutputVersions namedHL_Clause
2374+
syn keyword namedO_DnstapOutputVersions contained versions
23652375
\ skipwhite skipnl skipempty
23662376
\ nextgroup=
2367-
\ namedO_DnstapOutputVersionBuiltin,
2368-
\ namedO_DnstapOutputVersionNumber
2377+
\ namedO_DnstapOutputVersionsBuiltin,
2378+
\ namedO_DnstapOutputVersionsNumber
23692379

23702380
hi link namedO_DnstapOutputSize namedHL_Clause
23712381
syn keyword namedO_DnstapOutputSize contained size
@@ -2379,24 +2389,20 @@ syn keyword namedO_DnstapOutputSuffix contained suffix
23792389
\ skipwhite skipnl skipempty
23802390
\ nextgroup=namedO_DnstapOutputSuffixType
23812391

2382-
syn region namedO_DnstapOutputSection contained start=/\zs\S\ze/ end=/;/me=e-1
2383-
\ skipwhite skipnl skipempty
2384-
\ contains=
2392+
hi link namedO_DnstapOutputFilespec namedHL_String
2393+
syn match namedO_DnstapOutputFilespec contained /'[ a-zA-Z\]\-\[0-9\._,:;\/?<>|`~!@#$%\^&*\\(\\)+{}]\{1,256}'/hs=s+1,he=e-1
2394+
\ skipwhite skipempty skipnl
2395+
\ nextgroup=namedSemicolon,
23852396
\ namedO_DnstapOutputSuffix,
2386-
\ namedO_DnstapOutputVersion,
2387-
\ namedO_DnstapOutputSize
2388-
\ nextgroup=namedSemicolon
2397+
\ namedO_DnstapOutputSize,
2398+
\ namedO_DnstapOutputVersions
23892399

2390-
hi link namedO_DnstapOutputFilespec namedHL_String
2391-
syn match namedO_DnstapOutputFilespec contained /[a-zA-Z\]\-\[0-9\._,:\/?<>|'"`~!@#$%\^&*\\(\\)+]\{1,1024}/
2392-
\ skipwhite skipempty skipnl
2393-
\ nextgroup=namedO_DnstapOutputSection
2394-
syn match namedO_DnstapOutputFilespec contained /'[ a-zA-Z\]\-\[0-9\._,:;\/?<>|"`~!@#$%\^&*\\(\\)+{}]\{1,1024}'/hs=s+1,he=e-1
2395-
\ skipwhite skipempty skipnl
2396-
\ nextgroup=namedO_DnstapOutputSection
2397-
syn match namedO_DnstapOutputFilespec contained /"[ a-zA-Z\]\-\[0-9\._,:;\/?<>|'`~!@#$%\^&*\\(\\)+{}]\{1,1024}"/hs=s+1,he=e-1
2398-
\ skipwhite skipempty skipnl
2399-
\ nextgroup=namedO_DnstapOutputSection
2400+
syn match namedO_DnstapOutputFilespec contained /"[ a-zA-Z\]\-\[0-9\._,:;\/?<>|`~!@#$%\^&*\\(\\)+{}]\{1,256}"/hs=s+1,he=e-1
2401+
\ skipwhite skipempty skipnl
2402+
\ nextgroup=namedSemicolon,
2403+
\ namedO_DnstapOutputSuffix,
2404+
\ namedO_DnstapOutputSize,
2405+
\ namedO_DnstapOutputVersions
24002406

24012407
hi link namedO_DnstapOutputType namedHL_Clause
24022408
syn keyword namedO_DnstapOutputType contained skipwhite skipnl skipempty

test/github-issue-5-named.conf

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
options {
2+
dnstap-output 'dnstap.out';
3+
dnstap-output 'dnstap.out';
4+
dnstap-output "dnstap.out" ;
5+
dnstap-output "dnstap.out" ;
6+
dnstap-output "dnstap.out" ; ; ;
7+
dnstap-output "dnstap.out" ; ; ;
8+
dnstap-output "dnstap.out" ; ; ; ;
9+
dnstap-output "dnstap.out" ; ; ; ;
10+
dnstap-output file 'dnstap.out';
11+
dnstap-output file "dnstap.out"; ; ; ;
12+
dnstap-output file "dnstap.out" size 123;
13+
dnstap-output file "dnstap.out" size unlimited;
14+
dnstap-output file "dnstap.out" suffix increment;
15+
dnstap-output file "dnstap.out" suffix timestamp;
16+
dnstap-output file "dnstap.out" versions 23;
17+
dnstap-output file "dnstap.out" size unlimited suffix timestamp;
18+
dnstap-output file "dnstap.out" size 345 versions 3;
19+
dnstap-output file "dnstap.out" suffix increment versions 2;
20+
dnstap-output file "dnstap.out" size unlimited suffix timestamp versions 2;
21+
dnstap-output file "dnstap.out" versions 2 size 567 suffix increment;
22+
dnstap-output file "dnstap.out" versions 2 suffix timestamp size 789;
23+
dnstap { all; };
24+
send-cookie no;
25+
require-server-cookie no;
26+
minimal-responses no;
27+
dnssec-validation yes;
28+
qname-minimization disabled;
29+
};
30+
31+
view {
32+
dnstap { all; };
33+
};

0 commit comments

Comments
 (0)