[bug-OpenMage#933] Non-numeric value warning in Model_Url::getUnusedPathByUrlKey()

tmotyl · edannenberg · commit b7ec071bda68 · 2020-08-17T17:13:09.000+02:00
Cast value to int and change isset to !empty to prevent
url model to add empty string to a 1.
diff --git a/app/code/core/Mage/Catalog/Model/Url.php b/app/code/core/Mage/Catalog/Model/Url.php
@@ -676,7 +676,7 @@ public function getUnusedPathByUrlKey($storeId, $requestPath, $idPath, $urlKey)
                 $match['increment'] = $lastRequestPath;
             }
             return $match['prefix']
-                . (isset($match['increment']) ? ($match['increment'] + 1) : '1')
+                . (!empty($match['increment']) ? ((int)$match['increment'] + 1) : '1')
                 . $match['suffix'];
         }
         else {

Original file line number	Diff line number	Diff line change
`@@ -676,7 +676,7 @@ public function getUnusedPathByUrlKey($storeId, $requestPath, $idPath, $urlKey)`
`676`	`676`	`$match['increment'] = $lastRequestPath;`
`677`	`677`	`}`
`678`	`678`	`return $match['prefix']`
`679`		`- . (isset($match['increment']) ? ($match['increment'] + 1) : '1')`
	`679`	`+ . (!empty($match['increment']) ? ((int)$match['increment'] + 1) : '1')`
`680`	`680`	`. $match['suffix'];`
`681`	`681`	`}`
`682`	`682`	`else {`