feat: remove the now deprecated in editor codegen

Author: zaucy

Source/EcsactEditor/Private/EcsactEditor.cpp

@@ -217,14 +217,6 @@ auto FEcsactEditorModule::StartupModule() -> void {
 		),
 		SourcesWatchHandle
 	);
-	watcher->RegisterDirectoryChangedCallback_Handle(
-		PluginBinariesDir(),
-		IDirectoryWatcher::FDirectoryChanged::CreateRaw(
-			this,
-			&FEcsactEditorModule::OnPluginBinariesChanged
-		),
-		PluginBinariesWatchHandle
-	);
 
 	FEditorDelegates::OnEditorInitialized.AddRaw(
 		this,
@@ -407,16 +399,6 @@ auto FEcsactEditorModule::AddMenuEntry(FMenuBuilder& MenuBuilder) -> void {
 		LOCTEXT("EcsactToolsSectionTitle", "Ecsact")
 	);
 	{
-		MenuBuilder.AddMenuEntry(
-			LOCTEXT("EcsactRunCodegen", "Re-run codegen"),
-			LOCTEXT(
-				"EcsactRunCodegenTooltip",
-				"Re-runs the ecsact codegen. This usually happens automatically and is "
-				"not necessary to run manually from the menu."
-			),
-			FSlateIcon(),
-			FUIAction(FExecuteAction::CreateLambda([this] { RunCodegen(); }))
-		);
 		MenuBuilder.AddMenuEntry(
 			LOCTEXT("EcsactRebuild", "Rebuild runtime"),
 			LOCTEXT(
@@ -447,129 +429,13 @@ auto FEcsactEditorModule::OnProjectSourcesChanged(
 		UE_LOG(
 			EcsactEditor,
 			Log,
-			TEXT("Ecsact files changed. Re-generating C++ and rebuilding runtime ...")
+			TEXT("Ecsact files changed. Rebuilding runtime ...")
 		);
 
-		RunCodegen();
 		RunBuild();
 	}
 }
 
-auto FEcsactEditorModule::OnPluginBinariesChanged(
-	const TArray<FFileChangeData>& FileChanges
-) -> void {
-	auto any_codegen_plugins_changed = false;
-	auto plugin_ext = PlatformEcsactPluginExtension();
-	if(plugin_ext.IsEmpty()) {
-		return;
-	}
-
-	for(auto& change : FileChanges) {
-		if(!change.Filename.EndsWith(plugin_ext)) {
-			continue;
-		}
-
-		auto change_basename = FPaths::GetBaseFilename(change.Filename);
-		if(!change_basename.StartsWith("UnrealEditor-Ecsact")) {
-			continue;
-		}
-		if(!change_basename.Contains("CodegenPlugin")) {
-			continue;
-		}
-
-		auto dash_index = int32{};
-		if(change_basename.FindLastChar('-', dash_index)) {
-			auto plugin_name = change_basename.Mid(0, dash_index);
-			CodegenPluginHotReloadNames.Add(plugin_name, change_basename);
-		}
-
-		any_codegen_plugins_changed = true;
-	}
-
-	if(any_codegen_plugins_changed) {
-		UE_LOG(
-			EcsactEditor,
-			Log,
-			TEXT("Ecsact codegen plugins changed. Re-generating C++ ...")
-		);
-
-		RunCodegen();
-	}
-}
-
-auto FEcsactEditorModule::GetUnrealCodegenPlugins() -> TArray<FString> {
-	auto& fm = FPlatformFileManager::Get().GetPlatformFile();
-	auto  plugins_dir = FPaths::ProjectPluginsDir();
-	auto  plugin_dir = FPaths::Combine(plugins_dir, "Ecsact");
-
-	if(!fm.DirectoryExists(*plugin_dir)) {
-		UE_LOG(
-			EcsactEditor,
-			Error,
-			TEXT("Unable to find Ecsact Unreal integration plugin directory. Please "
-					 "make sure it is installed as 'Ecsact' and not by any other name")
-		);
-		return {};
-	}
-
-	auto codegen_plugin_name = CodegenPluginHotReloadNames.FindRef(
-		"UnrealEditor-EcsactUnrealCodegenPlugin",
-		"UnrealEditor-EcsactUnrealCodegenPlugin"
-	);
-
-	auto plugin_path = FPaths::Combine(
-		plugin_dir,
-		"Binaries",
-		PlatformBinariesDirname(),
-		codegen_plugin_name + PlatformEcsactPluginExtension()
-	);
-
-	if(fm.FileExists(*plugin_path)) {
-		return {plugin_path};
-	}
-
-	UE_LOG(EcsactEditor, Error, TEXT("Unable to find %s"), *plugin_path);
-
-	return {};
-}
-
-auto FEcsactEditorModule::RunCodegen() -> void {
-	auto ecsact_files = GetAllEcsactFiles();
-	auto args = TArray<FString>{
-		"codegen",
-		"--format=json",
-		"--plugin=cpp_header",
-		// "--plugin=systems_header",
-		// "--plugin=cpp_systems_header",
-		// "--plugin=cpp_systems_source",
-	};
-
-	for(auto plugin : GetUnrealCodegenPlugins()) {
-		args.Add("--plugin=" + plugin);
-	}
-
-	args.Append(ecsact_files);
-
-	SpawnEcsactCli(
-		args,
-		FOnReceiveLine::CreateLambda([this](FString Line) {
-			OnReceiveEcsactCliJsonMessage(Line);
-		}),
-		FOnExitDelegate::CreateLambda([](int32 ExitCode) -> void {
-			if(ExitCode == 0) {
-				UE_LOG(EcsactEditor, Log, TEXT("Ecsact codegen success"));
-			} else {
-				UE_LOG(
-					EcsactEditor,
-					Error,
-					TEXT("Ecsact codegen failed with exit code %i"),
-					ExitCode
-				);
-			}
-		})
-	);
-}
-
 auto FEcsactEditorModule::RunBuild() -> void {
 	const auto* settings = GetDefault<UEcsactSettings>();
 
@@ -673,7 +539,6 @@ auto FEcsactEditorModule::SupportsDynamicReloading() -> bool {
 }
 
 auto FEcsactEditorModule::OnEditorInitialized(double Duration) -> void {
-	RunCodegen();
 	RunBuild();
 }
 

Source/EcsactEditor/Public/EcsactEditor.h

@@ -9,9 +9,8 @@
 DECLARE_LOG_CATEGORY_EXTERN(EcsactEditor, Log, All);
 
 class ECSACTEDITOR_API FEcsactEditorModule : public IModuleInterface {
-	FDelegateHandle        SourcesWatchHandle;
-	FDelegateHandle        PluginBinariesWatchHandle;
-	TMap<FString, FString> CodegenPluginHotReloadNames;
+	FDelegateHandle SourcesWatchHandle;
+	FDelegateHandle PluginBinariesWatchHandle;
 
 public:
 	using FOnExitDelegate = TDelegate<void(int32)>;
@@ -28,7 +27,6 @@ class ECSACTEDITOR_API FEcsactEditorModule : public IModuleInterface {
 	) -> void;
 	auto OnReceiveEcsactCliJsonMessage(FString Json) -> void;
 	auto AddMenuEntry(class FMenuBuilder& MenuBuilder) -> void;
-	auto GetUnrealCodegenPlugins() -> TArray<FString>;
 	auto LoadRunnerSubsystemBlueprints() -> void;
 
 	auto OnAssetsAdded(TConstArrayView<FAssetData> Assets) -> void;
@@ -45,7 +43,6 @@ class ECSACTEDITOR_API FEcsactEditorModule : public IModuleInterface {
 
 	static auto GetAllEcsactFiles() -> TArray<FString>;
 
-	auto RunCodegen() -> void;
 	auto RunBuild() -> void;
 
 	auto StartupModule() -> void override;