fix: added missing implementations of connected/disconnected

Author: zaucy

Source/Ecsact/Public/EcsactUnreal/Ecsact.cpp

@@ -6,6 +6,7 @@
 #include "Misc/Paths.h"
 #include "EcsactUnreal/EcsactAsyncRunner.h"
 #include "ecsact/runtime.h"
+#include "Engine/World.h"
 
 #define LOCTEXT_NAMESPACE "FEcsactModule"
 

Source/Ecsact/Public/EcsactUnreal/EcsactAsyncRunner.cpp

@@ -41,8 +41,9 @@ auto UEcsactAsyncRunner::StreamImpl(
 }
 
 auto UEcsactAsyncRunner::Connect( //
-	const char*               ConnectionStr,
-	FAsyncRequestDoneCallback Callback
+	const char*                ConnectionStr,
+	FAsyncRequestErrorCallback ErrorCallback,
+	FAsyncRequestDoneCallback  Callback
 ) -> void {
 	auto req_id = ecsact_async_connect(ConnectionStr);
 	OnRequestDone(
@@ -54,6 +55,14 @@ auto UEcsactAsyncRunner::Connect( //
 			}
 		)
 	);
+	OnRequestError(
+		req_id,
+		FAsyncRequestErrorCallback::CreateLambda( //
+			[this, ErrorCallback = std::move(ErrorCallback)](ecsact_async_error err) {
+				ErrorCallback.ExecuteIfBound(err);
+			}
+		)
+	);
 }
 
 auto UEcsactAsyncRunner::Disconnect() -> void {
@@ -86,6 +95,13 @@ auto UEcsactAsyncRunner::OnAsyncErrorRaw(
 	for(auto req_id : request_ids) {
 		auto cbs = self->RequestErrorCallbacks.Find(req_id);
 
+		UE_LOG(
+			LogTemp,
+			Warning,
+			TEXT("Received request error raw (req=%i)"),
+			static_cast<int>(req_id)
+		);
+
 		if(cbs && !cbs->IsEmpty()) {
 			for(auto& cb : *cbs) {
 				if(!cb.ExecuteIfBound(async_err)) {
@@ -113,6 +129,8 @@ auto UEcsactAsyncRunner::OnExecuteSysErrorRaw(
 	void*                        callback_user_data
 ) -> void {
 	auto self = static_cast<ThisClass*>(callback_user_data);
+
+	UE_LOG(LogTemp, Warning, TEXT("System error"));
 }
 
 auto UEcsactAsyncRunner::OnAsyncRequestDoneRaw(
@@ -127,6 +145,13 @@ auto UEcsactAsyncRunner::OnAsyncRequestDoneRaw(
 	for(auto req_id : request_ids) {
 		auto cbs = self->RequestDoneCallbacks.Find(req_id);
 
+		UE_LOG(
+			LogTemp,
+			Warning,
+			TEXT("Received request done raw (req=%i)"),
+			static_cast<int>(req_id)
+		);
+
 		if(cbs && !cbs->IsEmpty()) {
 			for(auto& cb : *cbs) {
 				if(!cb.ExecuteIfBound()) {
@@ -190,6 +215,12 @@ auto UEcsactAsyncRunner::OnRequestDone(
 	FAsyncRequestDoneCallback Callback
 ) -> void {
 	check(RequestId != ECSACT_INVALID_ID(async_request));
+	UE_LOG(
+		LogTemp,
+		Warning,
+		TEXT("Adding request done handler (req=%i)"),
+		static_cast<int>(RequestId)
+	);
 	RequestDoneCallbacks.FindOrAdd(RequestId).Add(Callback);
 }
 
@@ -200,3 +231,11 @@ auto UEcsactAsyncRunner::OnRequestError(
 	check(RequestId != ECSACT_INVALID_ID(async_request));
 	RequestErrorCallbacks.FindOrAdd(RequestId).Add(Callback);
 }
+
+auto UEcsactAsyncRunner::OnConnect(TDelegate<void()> Callback) -> void {
+	GenericConnectCallbacks.Add(std::move(Callback));
+}
+
+auto UEcsactAsyncRunner::OnDisconnect(TDelegate<void()> Callback) -> void {
+	GenericDisconnectCallbacks.Add(std::move(Callback));
+}

Source/Ecsact/Public/EcsactUnreal/EcsactAsyncRunner.h

@@ -70,12 +70,17 @@ class ECSACT_API UEcsactAsyncRunner //
 	 * Wrapper around ecsact_async_connect
 	 */
 	auto Connect( //
-		const char*               ConnectionStr,
-		FAsyncRequestDoneCallback Callback
+		const char*                ConnectionStr,
+		FAsyncRequestErrorCallback ErrorCallback,
+		FAsyncRequestDoneCallback  Callback
 	) -> void;
 
 	auto Disconnect() -> void;
 
+	auto OnConnect(TDelegate<void()> Callback) -> void override;
+
+	auto OnDisconnect(TDelegate<void()> Callback) -> void override;
+
 	auto OnRequestDone(
 		ecsact_async_request_id   RequestId,
 		FAsyncRequestDoneCallback Callback