feat: add const qualifier to minst create (#86)

Author: Kelwan

.github/workflows/main.yml

@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: greut/eclint-action@v0
       - uses: jidicula/clang-format-action@v4.11.0
-        with: { clang-format-version: "19" }
+        with: { clang-format-version: "20" }
 
   test-windows:
     if: >-

ecsact/si/wasmer/detail/logger.cc

@@ -54,8 +54,9 @@ auto ecsact::wasm::detail::push_stdio_str(
 	_stdio_strings[level] += std::string(str);
 }
 
-auto ecsact::wasm::detail::consume_stdio_str_as_log_lines(const log_transaction&)
-	-> std::vector<log_line_entry> {
+auto ecsact::wasm::detail::consume_stdio_str_as_log_lines(
+	const log_transaction&
+) -> std::vector<log_line_entry> {
 	using namespace std::string_view_literals;
 
 	auto result = std::vector<log_line_entry>{};
@@ -74,10 +75,12 @@ auto ecsact::wasm::detail::consume_stdio_str_as_log_lines(const log_transaction&
 				continue;
 			}
 
-			result.push_back(log_line_entry{
-				.log_level = log_level,
-				.message = message,
-			});
+			result.push_back(
+				log_line_entry{
+					.log_level = log_level,
+					.message = message,
+				}
+			);
 		}
 	}
 

ecsact/si/wasmer/detail/minst/minst.cc

@@ -116,14 +116,15 @@ auto minst_trap::message() const -> std::string {
 
 auto minst::create( //
 	wasm_engine_t*       engine,
-	std::span<std::byte> wasm_data,
+	std::span<const std::byte> wasm_data,
 	import_resolver_t    import_resolver
 ) -> std::variant<minst, minst_error> {
 	auto self = minst{};
 
 	auto wasm_bytes = wasm_byte_vec_t{
 		.size = wasm_data.size(),
-		.data = reinterpret_cast<wasm_byte_t*>(wasm_data.data()),
+		.data =
+			reinterpret_cast<wasm_byte_t*>(const_cast<std::byte*>(wasm_data.data())),
 	};
 
 	self._engine = engine;

ecsact/si/wasmer/detail/minst/minst.hh

@@ -82,7 +82,7 @@ public:
 
 	static auto create( //
 		wasm_engine_t*       engine,
-		std::span<std::byte> wasm_data,
+		std::span<const std::byte> wasm_data,
 		import_resolver_t    import_resolver
 	) -> std::variant<minst, minst_error>;
 

ecsact/si/wasmer/detail/wasm.cc

@@ -172,7 +172,6 @@ ecsact_si_wasm_error ecsact_si_wasm_load(
 	}
 #endif
 	auto import_resolver = [&](const minst_import imp) -> minst_import_resolve_t {
-		auto module_name = imp.module();
 		auto method_name = imp.name();
 
 		if(imp.module() == "env") {