Skip to content

Commit 6132dcf

Browse files
committed
fix: entity created event first
* the event created event was happening _after_ init,update, and remove component events. The correct order is supposed to be create, init, update, remove and then destroy
1 parent 317dc29 commit 6132dcf

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

rt_entt_codegen/core/events.cc

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_minimal( //
3838
)
3939
.return_type("void");
4040

41+
ctx.write(
42+
"ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, "
43+
"events_collector);\n"
44+
);
45+
4146
for(auto comp_id : comps_with_caps(details, ECSACT_SYS_CAP_ADDS)) {
4247
auto type_name = cpp_identifier(decl_full_name(comp_id));
4348
print_trigger_event_fn_call(ctx, "init", type_name);
@@ -53,11 +58,6 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_minimal( //
5358
print_trigger_event_fn_call(ctx, "remove", type_name);
5459
}
5560

56-
ctx.write(
57-
"ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, "
58-
"events_collector);\n"
59-
);
60-
6161
ctx.write(
6262
"ecsact::entt::wrapper::core::_trigger_destroy_entity_events(registry_id, "
6363
"events_collector);\n"
@@ -81,6 +81,11 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_all( //
8181
)
8282
.return_type("void");
8383

84+
ctx.write(
85+
"ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, "
86+
"events_collector);\n"
87+
);
88+
8489
for(auto component_id : details.all_components) {
8590
auto type_name = cpp_identifier(decl_full_name(component_id));
8691
print_trigger_event_fn_call(ctx, "init", type_name);
@@ -101,11 +106,6 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_all( //
101106
print_trigger_event_fn_call(ctx, "remove", type_name);
102107
}
103108

104-
ctx.write(
105-
"ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, "
106-
"events_collector);\n"
107-
);
108-
109109
ctx.write(
110110
"ecsact::entt::wrapper::core::_trigger_destroy_entity_events(registry_id, "
111111
"events_collector);\n"

test/.bazelversion

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7.4.1

0 commit comments

Comments
 (0)