Skip to content

Commit 51d1372

Browse files
committed
code cleanup
1 parent 1d3a8c8 commit 51d1372

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,4 @@ e2e/test-results
5454
/tools/server/.lwjgl/
5555
.m2_repo/
5656
.serena/
57+
.vscode

tools/server-boot/src/main/java/org/eclipse/rdf4j/tools/serverboot/CssPathFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131

3232
/**
3333
* Replaces {@code ${path}} placeholders inside CSS responses after buffering the downstream output. The buffering
34-
* avoids calling {@link javax.servlet.ServletResponse#getWriter()} before the target resource starts writing,
35-
* preventing writer/output stream conflicts on binary responses.
34+
* avoids calling {@link ServletResponse#getWriter()} before the target resource starts writing, preventing
35+
* writer/output stream conflicts on binary responses.
3636
*/
3737
class CssPathFilter implements Filter {
3838

tools/server-boot/src/test/java/org/eclipse/rdf4j/server/boot/SolrAutoConfigurationTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.apache.solr.client.solrj.SolrClient;
1717
import org.eclipse.rdf4j.tools.serverboot.Rdf4jServerWorkbenchApplication;
1818
import org.junit.jupiter.api.Test;
19+
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
1920
import org.springframework.beans.factory.annotation.Autowired;
2021
import org.springframework.boot.test.context.SpringBootTest;
2122
import org.springframework.context.ApplicationContext;
@@ -29,6 +30,6 @@ class SolrAutoConfigurationTest {
2930
@Test
3031
void solrClientBeanNotPresentByDefault() {
3132
assertThatThrownBy(() -> applicationContext.getBean(SolrClient.class))
32-
.isInstanceOf(org.springframework.beans.factory.NoSuchBeanDefinitionException.class);
33+
.isInstanceOf(NoSuchBeanDefinitionException.class);
3334
}
3435
}

tools/server-boot/src/test/java/org/eclipse/rdf4j/tools/serverboot/ServerBootSignalIT.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121
import java.io.InputStreamReader;
2222
import java.net.ServerSocket;
2323
import java.nio.charset.StandardCharsets;
24+
import java.nio.file.Files;
2425
import java.nio.file.Path;
2526
import java.util.ArrayList;
27+
import java.util.Comparator;
2628
import java.util.List;
2729
import java.util.UUID;
2830
import java.util.concurrent.CountDownLatch;
@@ -91,12 +93,20 @@ void gracefullyStopsOnSigterm() throws Exception {
9193
private void assertGracefulShutdown(String signalName) throws Exception {
9294
Path projectRoot = Path.of("").toAbsolutePath();
9395
String javaBin = Path.of(System.getProperty("java.home"), "bin", "java").toString();
94-
String classpath = System.getProperty("java.class.path");
9596
int serverPort = findFreePort();
9697
int managementPort = findFreePort();
9798

98-
ProcessBuilder processBuilder = new ProcessBuilder(javaBin, "-cp", classpath,
99-
Rdf4jServerWorkbenchApplication.class.getName(),
99+
// Find the executable JAR
100+
Path targetDir = projectRoot.resolve("target");
101+
Path jarPath = Files.list(targetDir)
102+
.sorted(Comparator.comparing(Path::toString))
103+
.filter(p -> p.toString().endsWith(".jar"))
104+
.filter(p -> !p.toString().endsWith("-sources.jar"))
105+
.filter(p -> !p.toString().endsWith("-javadoc.jar"))
106+
.findFirst()
107+
.orElseThrow(() -> new IllegalStateException("Could not find executable JAR in " + targetDir));
108+
109+
ProcessBuilder processBuilder = new ProcessBuilder(javaBin, "-jar", jarPath.toString(),
100110
"--server.port=" + serverPort,
101111
"--management.server.port=" + managementPort);
102112
processBuilder.directory(projectRoot.toFile());

0 commit comments

Comments
 (0)