More clean-up actions

[vogella]

Somewhere (in the unmanageable amount of PR's) @laeubi suggested that I should activate more JDT clean-ups.

Happy to do this next week as I have a bit of time on my hand for Eclipse releated activities.

@jjohnstn or @laeubi which performance or other clean-ups can you recommend to activate?

[laeubi]

@vogella I'm not sure M3 week is the best to activate new cleanups (as there is less time to fix issues then), maybe it is better to wait for start of next release master opens? But of course it all depends a bit how dedicated you plan to work on these things.

What one usually can already do is to activate something that sounds useful, apply it to a few projects and then review the outcome to guess if it helps or if one can already discover some bugs.

[vogella]

I agree with M3, the activation of new clean-ups must not be merged, only because we have a new PR for this.

No particular suggestion for activation of clean-ups in the next release?

[vogella]

No suggestion at the moment

[laeubi]

No suggestion at the moment

I'm not sure what to suggest, last time you opened a PR with some cleanups applied and I suggested to do it automatically instead. So that would then be something to enable ...

[vogella]

I'm not aware of such a clean-up. If we do please let me know which one it is.

[laeubi]

I'm not aware of such a clean-up. If we do please let me know which one it is.

See for example here:

• Performance: Cache method calls in loops and optimize string concaten… #3515

in general I think we should prefer enabling cleanups when we stumble over it instead of making it manual/ (or AI semi automatic).

[laeubi]

Another example:

• TargetDefinition.java - Code Quality Improvements eclipse-pde/eclipse.pde#2058

[vogella]

Simplify lambda expression is not yet enabled? This one makes sense IHMO. Configuration for the clean-ups were in the aggregator repo, right?

[laeubi]

Simplify lambda expression is not yet enabled?

You get a textual representation of whats enabled when you look at any of the cleanup PRs

https://github.com/eclipse-platform/eclipse.platform.ui/pulls?q=is%3Apr+label%3Acleanup+is%3Aclosed

Configuration for the clean-ups were in the aggregator repo, right?

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/eclipse-platform-parent/pom.xml#L533-L575

This one makes sense IHMO

Many things are useful but each cleanup we enable requires some dedication to:

1. Identify and enable them
2. Review and merge PRs
3. Report bugs and issue to JDT and track progress there

[vogella]

AH, I just remembered, we cannot activate lambda clean because Equinox startup time was negatively effected and @tjwatson had to revert the changes. So unless @tjwatson tells us that this issue has been solved, we cannot activate this clean-up.