Performance: Cache method calls in loops and optimize string concatenation

Apply low-risk performance optimizations across multiple bundles:

Loop optimizations - cache method results:
- StyledString: Cache otherRuns.size() before loop
- ContributionManager: Cache contributions.size() in indexOf() and duplicate removal
- ContentProposalAdapter: Cache autoActivateString.length() in loop
- DialogSettings: Cache s.length() before character iteration
- MenuManagerShowProcessor: Cache menuModel.getChildren() to avoid repeated calls
- WorkbenchPage: Cache getChildren() results to avoid expensive repeated calls

String concatenation optimizations:
- WizardsRegistryReader: Use StringBuilder for path construction in loop
- NewContentTypeDialog: Use StringBuilder for name generation in while loop

Repeated expensive calls:
- BindingManager: Cache format().length() results in comparison
- MenuManagerShowProcessor: Cache getChildren() in loop condition and body

All changes are non-API breaking and maintain identical behavior while
reducing unnecessary object allocations and method calls.

Author: claude

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java

@@ -123,8 +123,8 @@ public void menuAboutToHide(IMenuManager manager) {
 	 * {@link MDynamicMenuContribution} application model elements
 	 */
 	private void processDynamicElements(MMenu menuModel, MenuManager menuManager) {
-		MMenuElement[] menuElements = menuModel.getChildren().toArray(
-				new MMenuElement[menuModel.getChildren().size()]);
+		List<MMenuElement> children = menuModel.getChildren();
+		MMenuElement[] menuElements = children.toArray(new MMenuElement[children.size()]);
 		for (MMenuElement currentMenuElement : menuElements) {
 
 			if (currentMenuElement instanceof MDynamicMenuContribution dmc) {
@@ -154,9 +154,9 @@ private void processDynamicElements(MMenu menuModel, MenuManager menuManager) {
 				if (mel.size() > 0) {
 
 					int position = 0;
-					while (position < menuModel.getChildren().size()) {
-						if (currentMenuElement == menuModel.getChildren().get(
-								position)) {
+					List<MMenuElement> currentChildren = menuModel.getChildren();
+					while (position < currentChildren.size()) {
+						if (currentMenuElement == currentChildren.get(position)) {
 							position++;
 							break;
 						}

bundles/org.eclipse.jface/src/org/eclipse/jface/action/ContributionManager.java

@@ -272,7 +272,8 @@ protected boolean hasDynamicItems() {
 	 * @return <code>int</code> the index or -1 if the item is not found
 	 */
 	public int indexOf(String id) {
-		for (int i = 0; i < contributions.size(); i++) {
+		int size = contributions.size();
+		for (int i = 0; i < size; i++) {
 			IContributionItem item = contributions.get(i);
 			String itemId = item.getId();
 			if (itemId != null && itemId.equalsIgnoreCase(id)) {
@@ -489,7 +490,8 @@ public boolean replaceItem(final String identifier,
 		itemAdded(replacementItem); // throws NPE if (replacementItem == null)
 
 		// Go through and remove duplicates.
-		for (int i = contributions.size() - 1; i > index; i--) {
+		int size = contributions.size();
+		for (int i = size - 1; i > index; i--) {
 			IContributionItem item = contributions.get(i);
 			if ((item != null) && (identifier.equals(item.getId()))) {
 				if (Policy.TRACE_TOOLBAR) {

bundles/org.eclipse.jface/src/org/eclipse/jface/bindings/BindingManager.java

@@ -1339,8 +1339,9 @@ public TriggerSequence getBestActiveBindingFor(final ParameterizedCommand comman
 			}
 
 			// If this is still a tie, then just chose the shortest text.
-			compareTo = bestTriggerSequence.format().length()
-					- currentTriggerSequence.format().length();
+			int bestLength = bestTriggerSequence.format().length();
+			int currentLength = currentTriggerSequence.format().length();
+			compareTo = bestLength - currentLength;
 			if (compareTo > 0) {
 				bestBinding = currentBinding;
 			}

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogSettings.java

@@ -535,7 +535,8 @@ private static void appendEscapedChar(StringBuilder buffer, char c) {
 
 		private static String getEscaped(String s) {
 			StringBuilder result = new StringBuilder(s.length() + 10);
-			for (int i = 0; i < s.length(); ++i) {
+			int length = s.length();
+		for (int i = 0; i < length; ++i) {
 				appendEscapedChar(result, s.charAt(i));
 			}
 			return result.toString();

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/ContentProposalAdapter.java

@@ -2153,7 +2153,8 @@ private boolean shouldPopupRemainOpen() {
 			return true;
 		}
 		String content = getControlContentAdapter().getControlContents(getControl());
-		for (int i=0; i<autoActivateString.length(); i++) {
+		int length = autoActivateString.length();
+		for (int i=0; i<length; i++) {
 			if (content.indexOf(autoActivateString.charAt(i)) >= 0) {
 				return true;
 			}

bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StyledString.java

@@ -234,7 +234,8 @@ public StyledString append(StyledString string) {
 
 		List<StyleRun> otherRuns = string.fStyleRuns;
 		if (otherRuns != null && !otherRuns.isEmpty()) {
-			for (int i = 0; i < otherRuns.size(); i++) {
+			int size = otherRuns.size();
+			for (int i = 0; i < size; i++) {
 				StyleRun curr = otherRuns.get(i);
 				if (i == 0 && curr.offset != 0) {
 					appendStyleRun(null, offset); // appended string will

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchPage.java

@@ -3423,16 +3423,18 @@ public void resetPerspective() {
 		// Hide placeholders for parts that exist in the 'global' areas
 		modelService.hideLocalPlaceholders(window, dummyPerspective);
 
-		int dCount = dummyPerspective.getChildren().size();
-		while (!dummyPerspective.getChildren().isEmpty()) {
-			MPartSashContainerElement dChild = dummyPerspective.getChildren().remove(0);
-			persp.getChildren().add(dChild);
+		List<MPartSashContainerElement> dummyChildren = dummyPerspective.getChildren();
+		List<MPartSashContainerElement> perspChildren = persp.getChildren();
+		int dCount = dummyChildren.size();
+		while (!dummyChildren.isEmpty()) {
+			MPartSashContainerElement dChild = dummyChildren.remove(0);
+			perspChildren.add(dChild);
 		}
 
-		while (persp.getChildren().size() > dCount) {
-			MUIElement child = persp.getChildren().get(0);
+		while (perspChildren.size() > dCount) {
+			MUIElement child = perspChildren.get(0);
 			child.setToBeRendered(false);
-			persp.getChildren().remove(0);
+			perspChildren.remove(0);
 		}
 
 		List<MWindow> existingDetachedWindows = new ArrayList<>();

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/NewContentTypeDialog.java

@@ -54,7 +54,7 @@ protected NewContentTypeDialog(Shell parentShell, IContentTypeManager manager, I
 		}
 		int suffix = 2;
 		while (manager.getContentType(name) != null) {
-			name = baseName + " (" + suffix + ')'; //$NON-NLS-1$
+			name = new StringBuilder(baseName).append(" (").append(suffix).append(')').toString(); //$NON-NLS-1$
 			suffix++;
 		}
 	}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/registry/WizardsRegistryReader.java

@@ -76,14 +76,15 @@ private static class CategoryNode {
 
 		CategoryNode(Category cat) {
 			category = cat;
-			path = ""; //$NON-NLS-1$
 			String[] categoryPath = category.getParentPath();
+			StringBuilder pathBuilder = new StringBuilder();
 			if (categoryPath != null) {
 				for (String parentPath : categoryPath) {
-					path += parentPath + '/';
+					pathBuilder.append(parentPath).append('/');
 				}
 			}
-			path += cat.getId();
+			pathBuilder.append(cat.getId());
+			path = pathBuilder.toString();
 		}
 
 		String getPath() {