#30 added rollup-plugin-typescript-paths manually until MR is merged: simonhaenisch/rollup-plugin-typescript-paths#16

bennobuilder · bennobuilder · commit 8716974376a5 · 2023-07-14T07:16:07.000+02:00
diff --git a/package.json b/package.json
@@ -42,6 +42,7 @@
     "rollup-plugin-visualizer": "^5.9.0",
     "shx": "^0.3.4",
     "turbo": "^1.9.3",
+    "typescript": "^5.1.6",
     "yargs": "^17.7.2"
   },
   "engines": {
diff --git a/packages/core-client/tsconfig.prod.json b/packages/core-client/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/discord-handler/tsconfig.prod.json b/packages/discord-handler/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/dtif-to-svg/tsconfig.prod.json b/packages/dtif-to-svg/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/etsy-client/tsconfig.prod.json b/packages/etsy-client/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/logger/tsconfig.prod.json b/packages/logger/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/music/tsconfig.prod.json b/packages/music/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/openapi-fetch/tsconfig.prod.json b/packages/openapi-fetch/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/product-renderer/tsconfig.prod.json b/packages/product-renderer/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/svgson/tsconfig.prod.json b/packages/svgson/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/packages/utils/tsconfig.prod.json b/packages/utils/tsconfig.prod.json
@@ -1,5 +1,5 @@
 {
-  "extends": "./tsconfig",
+  "extends": "./tsconfig.json",
   "exclude": [
     "**/__tests__/*",
     "**/*.test.ts"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/scripts/rollup/create-package-config.ts b/scripts/rollup/create-package-config.ts
@@ -13,9 +13,9 @@ import {
 import bundleSize from 'rollup-plugin-bundle-size';
 import esbuild from 'rollup-plugin-esbuild';
 import nodeExternals from 'rollup-plugin-node-externals';
-import { typescriptPaths } from 'rollup-plugin-typescript-paths';
 import { visualizer } from 'rollup-plugin-visualizer';
 import { Logger } from '../utils';
+import { typescriptPaths } from './plugins/rollup-plugin-typescript-paths';
 
 const logger = new Logger('create-package-config');
 
@@ -86,6 +86,7 @@ export function createPackageConfig(options: TCreatePackageOptions = {}) {
         // Automatically resolve path aliases set in the compilerOptions section of tsconfig.json
         typescriptPaths({
           tsConfigPath: tsconfig,
+          preserveExtensions: true,
         }),
         // Transpile TypeScript code to JavaScript (ES6), and minify in production
         esbuild({
diff --git a/scripts/rollup/plugins/rollup-plugin-typescript-paths.ts b/scripts/rollup/plugins/rollup-plugin-typescript-paths.ts
@@ -0,0 +1,204 @@
+import path from 'path';
+import { Plugin } from 'rollup';
+import {
+  CompilerOptions,
+  findConfigFile,
+  nodeModuleNameResolver,
+  parseConfigFileTextToJson,
+  sys,
+} from 'typescript';
+
+export const typescriptPaths = ({
+  absolute = true,
+  nonRelative = false,
+  preserveExtensions = false,
+  tsConfigPath = findConfigFile('./', sys.fileExists),
+  transform,
+}: Options = {}): Plugin => {
+  const { compilerOptions } = getTsConfig(tsConfigPath);
+  const outDir = compilerOptions.outDir ?? '.';
+
+  return {
+    name: 'resolve-typescript-paths',
+    resolveId: (importee: string, importer?: string) => {
+      const enabled = Boolean(
+        compilerOptions.paths || (compilerOptions.baseUrl && nonRelative)
+      );
+
+      if (
+        typeof importer === 'undefined' ||
+        importee.startsWith('\0') ||
+        !enabled
+      ) {
+        return null;
+      }
+
+      const hasMatchingPath =
+        !!compilerOptions.paths &&
+        Object.keys(compilerOptions.paths).some((path) =>
+          new RegExp('^' + path.replace('*', '.+') + '$').test(importee)
+        );
+
+      if (!hasMatchingPath && !nonRelative) {
+        return null;
+      }
+
+      if (importee.startsWith('.')) {
+        return null; // never resolve relative modules, only non-relative
+      }
+
+      const { resolvedModule } = nodeModuleNameResolver(
+        importee,
+        importer,
+        compilerOptions,
+        sys
+      );
+
+      if (!resolvedModule) {
+        return null;
+      }
+
+      const { resolvedFileName } = resolvedModule;
+
+      if (!resolvedFileName || resolvedFileName.endsWith('.d.ts')) {
+        return null;
+      }
+
+      const targetFileName = path.join(
+        outDir,
+        preserveExtensions
+          ? resolvedFileName
+          : resolvedFileName.replace(/\.tsx?$/i, '.js')
+      );
+
+      const resolved = absolute
+        ? sys.resolvePath(targetFileName)
+        : targetFileName;
+
+      return transform ? transform(resolved) : resolved;
+    },
+  };
+};
+
+const getTsConfig = (configPath?: string): TsConfig => {
+  const defaults: TsConfig = { compilerOptions: { outDir: '.' } };
+  if (typeof configPath !== 'string') {
+    return defaults;
+  }
+
+  // Read in tsconfig.json
+  const configJson = sys.readFile(configPath);
+  if (configJson == null) {
+    return defaults;
+  }
+
+  const { config: rootConfig } = parseConfigFileTextToJson(
+    configPath,
+    configJson
+  );
+  const rootConfigWithDefaults = {
+    ...rootConfig,
+    ...defaults,
+    compilerOptions: {
+      ...defaults.compilerOptions,
+      ...(rootConfig.compilerOptions ?? {}),
+    },
+  };
+  const resolvedConfig = handleTsConfigExtends(
+    rootConfigWithDefaults,
+    configPath
+  );
+
+  return resolvedConfig;
+};
+
+const handleTsConfigExtends = (
+  config: TsConfig,
+  rootConfigPath: string
+): TsConfig => {
+  if (!('extends' in config) || typeof config.extends !== 'string') {
+    return config;
+  }
+
+  let extendedConfigPath;
+  try {
+    // Try to resolve as a module (npm)
+    extendedConfigPath = require.resolve(config.extends);
+  } catch (e) {
+    // Try to resolve as a file relative to the current config
+    extendedConfigPath = path.join(
+      path.dirname(rootConfigPath),
+      config.extends
+    );
+  }
+
+  // Read in extended tsconfig.json
+  const extendedConfig = getTsConfig(extendedConfigPath);
+
+  // Merge base config and current config.
+  // This does not handle array concatenation or nested objects,
+  // besides 'compilerOptions' paths as the other options are not relevant
+  config = {
+    ...extendedConfig,
+    ...config,
+    compilerOptions: {
+      ...extendedConfig.compilerOptions,
+      ...config.compilerOptions,
+      paths: {
+        ...(extendedConfig.compilerOptions.paths ?? {}),
+        ...(config.compilerOptions.paths ?? {}),
+      },
+    },
+  };
+
+  // Remove the "extends" field
+  delete config.extends;
+
+  return config;
+};
+
+export interface Options {
+  /**
+   * Whether to resolve to absolute paths; defaults to `true`.
+   */
+  absolute?: boolean;
+
+  /**
+   * Whether to resolve non-relative paths based on tsconfig's `baseUrl`, even
+   * if none of the `paths` are matched; defaults to `false`.
+   *
+   * @see https://www.typescriptlang.org/docs/handbook/module-resolution.html#relative-vs-non-relative-module-imports
+   * @see https://www.typescriptlang.org/docs/handbook/module-resolution.html#base-url
+   */
+  nonRelative?: boolean;
+
+  /**
+   * Whether to preserve `.ts` and `.tsx` file extensions instead of having them
+   * changed to `.js`; defaults to `false`.
+   */
+  preserveExtensions?: boolean;
+
+  /**
+   * Custom path to your `tsconfig.json`. Use this if the plugin can't seem to
+   * find the correct one by itself.
+   */
+  tsConfigPath?: string;
+
+  /**
+   * If the plugin successfully resolves a path, this function allows you to
+   * hook into the process and transform that path before it is returned.
+   */
+  transform?(path: string): string;
+}
+
+interface TsConfig {
+  compilerOptions: CompilerOptions;
+  extends?: string;
+}
+
+/**
+ * For backwards compatibility.
+ */
+export const resolveTypescriptPaths = typescriptPaths;
+
+export default typescriptPaths;

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "extends": "./tsconfig",`
	`2`	`+ "extends": "./tsconfig.json",`
`3`	`3`	`"exclude": [`
`4`	`4`	`"*/__tests__/",`
`5`	`5`	`"*/.test.ts"`