Skip to content

Commit d46c84e

Browse files
AbsurdlySuspiciousdwolfhub
authored andcommitted
use shallow copy for ranked dicts when user_inputs are present
1 parent 590ec08 commit d46c84e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

zxcvbn/matching.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from . import adjacency_graphs
33
import re
44
import functools
5+
import copy
56

67
from zxcvbn.scoring import most_guessable_match_sequence
78

@@ -105,10 +106,9 @@ def add_frequency_lists(frequency_lists_, *, _ranked_dictionaries):
105106
# omnimatch -- perform all matches
106107
@ensure_ranked_dictionaries
107108
def omnimatch(password, _ranked_dictionaries=None, user_inputs=[]):
108-
if len(user_inputs):
109+
if _ranked_dictionaries is not None and user_inputs:
110+
_ranked_dictionaries = copy.copy(_ranked_dictionaries)
109111
_ranked_dictionaries['user_inputs'] = build_ranked_dict(user_inputs)
110-
elif 'user_inputs' in _ranked_dictionaries:
111-
del(_ranked_dictionaries['user_inputs'])
112112

113113
matches = []
114114
for matcher in [

0 commit comments

Comments
 (0)