Remove unnecessary funcs and impl Display

Author: nozwock

src/handlers/submission.rs

@@ -183,33 +183,3 @@ impl std::fmt::Display for SubmitWrong {
         )
     }
 }
-
-impl SubmitWrong {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}
-
-impl SubmitLimitExceeded {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}
-
-impl SubmitCorrect {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}
-
-impl SubmitCompileError {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}
-
-impl SubmitRuntimeError {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}

src/handlers/user.rs

@@ -1,3 +1,5 @@
+use std::fmt;
+
 use serde::Deserialize;
 
 #[derive(Debug, Deserialize)]
@@ -9,14 +11,8 @@ pub struct UserMetadata {
     pub ac_hard: u16,
 }
 
-impl UserMetadata {
-    pub fn display(&self) {
-        println!("{}", self);
-    }
-}
-
-impl std::fmt::Display for UserMetadata {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+impl fmt::Display for UserMetadata {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(
             f,
             "{:18}:{:>15}\n{qs:18}:\n{empty:8}{easy:10}:{ec:>15}\n{empty:8}{med:10}:{mc:>15}\n{empty:8}{hard:10}:{hc:>15}",

src/handlers/utils.rs

@@ -1,9 +1,11 @@
+use std::fmt;
+
 use super::execution::*;
 use super::submission::*;
 use colored::Colorize;
 use serde::Deserialize;
 
-#[derive(Deserialize)]
+#[derive(Debug, Deserialize)]
 #[serde(untagged)]
 pub enum SubmissionResult {
     Success(SubmitCorrect),
@@ -42,24 +44,38 @@ pub struct Question {
     pub exampleTestcaseList: Vec<String>,
 }
 
-#[derive(Deserialize)]
+#[derive(Debug, Deserialize)]
 pub struct PendingResult {
     pub(crate) state: String,
 }
 
-#[derive(Deserialize)]
+#[derive(Debug, Deserialize)]
 pub struct Unknown {}
 
+impl fmt::Display for SubmissionResult {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {
+            SubmissionResult::Success(inner) => write!(f, "{}", inner),
+            SubmissionResult::CompileError(inner) => write!(f, "{}", inner),
+            SubmissionResult::RuntimeError(inner) => write!(f, "{}", inner),
+            SubmissionResult::Wrong(inner) => write!(f, "{}", inner),
+            SubmissionResult::LimitExceeded(inner) => write!(f, "{}", inner),
+            SubmissionResult::PendingResult(inner) => write!(f, "{}", inner),
+            SubmissionResult::Unknown(inner) => write!(f, "Unknown"),
+        }
+    }
+}
+
 impl PendingResult {
     pub fn state(&self) -> PendingState {
         match self.state.as_str() {
             "PENDING" => PendingState::Pending,
             "STARTED" => PendingState::Started,
             "SUCCESS" => PendingState::Success,
-            unknown_state => {
+            other => {
                 println!(
                     "Unknown state : {}\nKindly inform about this to the developer",
-                    unknown_state.cyan().bold()
+                    other.cyan().bold()
                 );
                 PendingState::Unknown
             }

src/main.rs

@@ -27,7 +27,7 @@ fn main() -> Result<()> {
 
     match cli.command {
         Some(Commands::Auth) => match lc.get_metadata() {
-            Ok(metadata) => metadata.display(),
+            Ok(metadata) => println!("{}", metadata),
             Err(err) => bail!(err),
         },
         Some(Commands::DailyChallenge) => {

src/utils.rs

@@ -78,7 +78,7 @@ pub(crate) fn execute_testcases<P: AsRef<Path>>(
 
 pub(crate) fn submit(lc: &LeetCode<Authorized>, code_file: CodeFile) -> Result<()> {
     match lc.submit(&code_file)? {
-        SubmissionResult::Success(success) => success.display(),
+        SubmissionResult::Success(success) => println!("{}", success),
         SubmissionResult::LimitExceeded(wrong) => {
             bail!(wrong)
         }