detector service for breakage reporting #2052

jdorweiler · 2025-11-10T23:42:18Z

Asana Task/Github Issue:

Description

Building on #2048 with a more generalize framework for breakage reports.

New detector service:

Registry + caching with configurable TTL
Auto-registration from remote config during page load
Optional auto-run with configurable delay (default 100ms)
Domain gating + custom shouldRun() checks (only during auto-run)
Multi-consumer design (any feature can import and use)

Changed:

Architecture: Service with dynamic registration
Caching: Built-in with TTL vs re-scan every call
Configuration: Remote config vs function parameters
Lifecycle: Auto-registers on page load + optional auto-run vs on-demand only
Gating: Domain restrictions + custom checks
Consumers: Any feature can use service

See the injected/src/detectors/README.md for more details

Testing Steps

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

netlify · 2025-11-10T23:42:24Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`443628a`
🔍 Latest deploy log	https://app.netlify.com/projects/content-scope-scripts/deploys/6914ab5855938a0008463a97
😎 Deploy Preview	https://deploy-preview-2052--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-11-10T23:42:52Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-2052
Commit Hash: 3cb35b42abf132239e11509f472190af6af19011
Last Updated: November 12, 2025 at 3:46:14 PM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#3cb35b42abf132239e11509f472190af6af19011

Please use the above install command to update to the latest version.

github-actions · 2025-11-10T23:43:21Z

[Beta] Generated file diff

Time updated: Wed, 12 Nov 2025 15:46:34 GMT

Android

    - android/adsjsContentScope.js

android/autofillImport.js
android/brokerProtection.js
android/contentScope.js

File has changed

Apple

    - apple/contentScope.js

apple/contentScopeIsolated.js

File has changed

Chrome-mv3

    - chrome-mv3/inject.js

File has changed

Firefox

    - firefox/inject.js

File has changed

Integration

    - integration/contentScope.js

File has changed

Windows

    - windows/contentScope.js

File has changed

madblex

This looks great. I added some comments and a couple more here:

I'd like to see how this integrates with content features, especially broker protection, i.e. the equivalent of this
I see we removed WebInterferenceDetection content feature. Is it because you don't think we'll need a standalone feature for this? i.e. the detectors will only be called from other features.
I see we're going the functional route (from classes). Not feeling strongly (I prefer functional most of the time), I just believe the trade-off is that interfaces will be more difficult to enforce. I think classes provide a bit of a better structure, but this is opinionated.

madblex · 2025-11-11T09:55:31Z

injected/src/content-scope-features.js

    const bundledFeatureNames = typeof importConfig.injectName === 'string' ? platformSupport[importConfig.injectName] : [];

+    // Initialize detectors early so they're available when features init
+    initDetectors(args.bundledConfig);


This is running on a critical path, I believe we should surround it with try/catch and fire a pixel on error here.

💯 good catch

madblex · 2025-11-11T10:02:03Z

injected/src/detectors/detector-service.js

+ * @param {boolean} [options._autoRun] - Internal flag indicating auto-run (gates apply)
+ * @returns {Promise<Record<string, any>>} Object mapping detector IDs to their data
+ */
+export async function getDetectorBatch(detectorIds, options = {}) {


We should use a better name here, currently it's a bit misleading. getDetectorBatch makes me think we're just getting the detectors based on args, not that they'll also be running. Suggestions:

runDetectors / getDetectorsData, etc.

Since this is also a "public" service to the repo, I'd interject the word web to make it clear what these detectors are about, i.e. runWebDetectors / getWebDetectorsData or similar.

Yeah good point. I'll go with getDetectorsData. I don't think we need web prefix as we're not following that naming scheme elsewhere (e.g., getJsPerformanceMetrics, getExpandedPerformanceMetrics)

madblex · 2025-11-11T10:07:00Z

injected/src/detectors/detections/detection-base.js

Will we still be needing this?

No, I can drop this

injected/src/detectors/detector-service.js

madblex · 2025-11-11T10:15:51Z

injected/src/detectors/detections/youtube-ads-detection.js

@@ -0,0 +1,62 @@
+import { isVisible, queryAllSelectors } from '../utils/detection-utils.js';
+const DEFAULT_CONFIG = {


Why not add to DEFAULT_DETECTOR_SETTINGS?

jdorweiler · 2025-11-11T15:24:47Z

This looks great. I added some comments and a couple more here:

1. I'd like to see how this integrates with content features, especially broker protection, i.e. the equivalent of [this](https://github.com/duckduckgo/content-scope-scripts/pull/2048/files#r2513656558)

2. I see we removed `WebInterferenceDetection` content feature. Is it because you don't think we'll need a standalone feature for this? i.e. the detectors will **only** be called from other features.

3. I see we're going the functional route (from classes). Not feeling strongly (I prefer functional most of the time), I just believe the trade-off is that interfaces will be more difficult to enforce. I think classes provide a bit of a better structure, but this is opinionated.

Commented here https://github.com/duckduckgo/content-scope-scripts/pull/2048/files#r2514564110
Yeah, I changed it so detectors auto register via detector-init.js during the load phase, and features import the service directly. So detector initialization is handled for you. Then you just need to add the message handler to broker protection (see my comment linked in 1)
I'm not strongly attached to this approach. I wanted to see what functional approach looked like vs classes but I'm open to switching to classes if you think the structure is worth it.

madblex and others added 10 commits November 6, 2025 17:41

feat: web interference detection prototype

5e9d02f

detector prototype v2

3abdc05

init and service

f241a6d

update readme

5653ae3

update readme

be56f76

update readme

e2d8317

add auto run

f5abfad

drop global domains option

8096a9c

update readme

cfe918c

remove old file

45b6115

jdorweiler assigned jonathanKingston and madblex Nov 10, 2025

madblex reviewed Nov 11, 2025

View reviewed changes

jdorweiler added 2 commits November 12, 2025 08:34

pr review changes, drop yt detector

6f45c6e

fix type erros

443628a

		@@ -0,0 +1,62 @@
		import { isVisible, queryAllSelectors } from '../utils/detection-utils.js';
		const DEFAULT_CONFIG = {

detector service for breakage reporting #2052

Are you sure you want to change the base?

detector service for breakage reporting #2052

Conversation

jdorweiler commented Nov 10, 2025

Description

Testing Steps

Checklist

Uh oh!

netlify bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for content-scope-scripts ready!

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Temporary Branch Update

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Beta] Generated file diff

Uh oh!

madblex left a comment

Choose a reason for hiding this comment

Uh oh!

madblex Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

jdorweiler Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

madblex Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

jdorweiler Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

madblex Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

jdorweiler Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

madblex Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

jdorweiler commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Nov 10, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading