Skip to content

Commit 3507b6c

Browse files
committed
Add cookiePopUpBlocked to TrackingStatus
1 parent 22f58f4 commit 3507b6c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

special-pages/pages/new-tab/app/activity/components/Activity.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { ActivityContext, ActivityServiceContext } from '../ActivityProvider.js'
66
import { useTypedTranslationWith } from '../../types.js';
77
import { useOnMiddleClick } from '../../utils.js';
88
import { useAdBlocking, useBatchedActivityApi, usePlatformName } from '../../settings.provider.js';
9-
import { Trans } from '../../../../../shared/components/TranslationsProvider.js';
109
import { ActivityItem } from './ActivityItem.js';
1110
import { ActivityBurningSignalContext, BurnProvider } from '../../burning/BurnProvider.js';
1211
import { useEnv } from '../../../../../shared/components/EnvironmentProvider.js';
@@ -181,13 +180,10 @@ function TrackerStatus({ id, trackersFound }) {
181180
const { t } = useTypedTranslationWith(/** @type {enStrings} */ ({}));
182181
const { activity } = useContext(NormalizedDataContext);
183182
const status = useComputed(() => activity.value.trackingStatus[id]);
184-
// @todo jingram add `cookiePopUpBlocked`
185-
const {totalCount, trackerCompanies} = status.value;
186-
const cookiePopUpBlocked = true;
183+
const {totalCount, trackerCompanies, cookiePopUpBlocked} = status.value;
187184
const other = trackerCompanies.slice(DDG_MAX_TRACKER_ICONS - 1);
188185
const adBlocking = useAdBlocking();
189186

190-
191187
let otherIcon = null;
192188
if (other.length > 0) {
193189
const title = other.map((item) => item.displayName).join('\n');

special-pages/pages/new-tab/app/activity/components/Activity.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@
197197
}
198198

199199
.companiesText {
200-
& div:first-of-type {
200+
& div:first-of-type:not(:only-child) {
201201
margin-bottom: 6px;
202202
}
203203
}

special-pages/pages/new-tab/messages/types/activity.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@
4545
},
4646
"favorite": {
4747
"type": "boolean"
48+
},
49+
"cookiePopUpBlocked": {
50+
"type": ["boolean", "null"],
51+
"description": "A cookie pop-up has been blocked for the specific domain"
4852
}
4953
},
5054
"required": ["etldPlusOne", "title", "url", "trackingStatus", "trackersFound", "history", "favorite", "favicon"]
@@ -91,4 +95,4 @@
9195
"required": ["title", "url", "relativeTime"]
9296
}
9397
}
94-
}
98+
}

0 commit comments

Comments
 (0)