Move BrowserPopupMenu to Browser-ui #7117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 13, 2025
Merged
Task/Issue URL: #7118 ### Description Translations for new Duck.ai Menu --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1211921638789395
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211821284193236?focus=true ### Description This PR adds the new Duck.ai Menu ### Steps to test this PR _Duck.ai Menu_ - [x] Open app and enable fullscreen mode Duck.ai - [x] Open a new chat - [x] Open the Browser Menu - [x] Verify new menu is visible --------- Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
joshliebe
reviewed
Nov 18, 2025
app/src/androidTest/java/com/duckduckgo/espresso/privacy/SurrogatesTest.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 18, 2025
| import com.duckduckgo.common.ui.view.gone | ||
| import com.duckduckgo.mobile.android.R.drawable | ||
|
|
||
| class BrowserMenu( |
Contributor
There was a problem hiding this comment.
There’s a lot to review here, I noticed that !displayedInCustomTabScreen is no longer checked. Just making sure that that is intended?
joshliebe
reviewed
Nov 18, 2025
| vpnMenuItem.isVisible = false | ||
| } | ||
| VpnMenuState.NotSubscribed -> { | ||
| vpnMenuItem.isVisible = true |
Contributor
There was a problem hiding this comment.
As well as !browserShowing is not used anymore, these are now true
Contributor
|
On new tab, the new tab button is missing: |
Contributor
|
New tab button also missing on malicious sites: |
Contributor
|
New tab is back, only thing I couldn’t test is "VPN" I see on prod: |
joshliebe
approved these changes
Nov 19, 2025
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
Works as expected, LGTM 🚀
malmstein
deleted the
feature/david/11-13-move_browserpopupmenu_to_browser-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211921638789392?focus=true
Description
This PR moves the BrowserMenu to the browser-ui module for ease of use
Lint is going to complain because of strings, this will be fixed on a stacked PR
Steps to test this PR
Browser mode
New Tab mode
Custom Tabs
Malicious sites