Ensure library init is async (#7243)

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212198371544796

### Description
Ensure URL prediction library initialization is async. Bumped the library version too.

### Steps to test this PR

_Test_
- [ ] Repeat tests from #7126

Author: aitorvs

app/src/main/java/com/duckduckgo/app/browser/omnibar/QueryUrlConverter.kt

@@ -33,12 +33,14 @@ import com.duckduckgo.privacy.config.api.PrivacyConfigCallbackPlugin
 import com.duckduckgo.urlpredictor.Decision
 import com.squareup.anvil.annotations.ContributesBinding
 import com.squareup.anvil.annotations.ContributesMultibinding
+import dagger.SingleInstanceIn
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
 @ContributesBinding(AppScope::class, boundType = OmnibarEntryConverter::class)
 @ContributesMultibinding(scope = AppScope::class, boundType = PrivacyConfigCallbackPlugin::class)
+@SingleInstanceIn(scope = AppScope::class)
 class QueryUrlConverter @Inject constructor(
     private val requestRewriter: RequestRewriter,
     private val androidBrowserConfigFeature: AndroidBrowserConfigFeature,
@@ -67,7 +69,7 @@ class QueryUrlConverter @Inject constructor(
         val isUrl = when (queryOrigin) {
             is QueryOrigin.FromAutocomplete -> queryOrigin.isNav
             is QueryOrigin.FromUser, QueryOrigin.FromBookmark -> {
-                if (useUrlPredictor) {
+                if (useUrlPredictor && queryUrlPredictor.isReady()) {
                     var queryClassification = queryUrlPredictor.classify(input = searchQuery)
 
                     if (extractUrlFromQuery) {

app/src/main/java/com/duckduckgo/app/browser/omnibar/QueryUrlPredictor.kt

@@ -16,16 +16,51 @@
 
 package com.duckduckgo.app.browser.omnibar
 
+import com.duckduckgo.app.di.AppCoroutineScope
+import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.urlpredictor.Decision
 import com.duckduckgo.urlpredictor.UrlPredictor
 import com.squareup.anvil.annotations.ContributesBinding
+import dagger.SingleInstanceIn
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.launch
+import logcat.logcat
 import javax.inject.Inject
 
 interface QueryUrlPredictor {
 
+    /**
+     * Indicates whether the UrlPredictor native library is ready to be used.
+     *
+     * This method is a convenience wrapper around {@link UrlPredictor#isInitialized()},
+     * exposing the initialization state at the application layer.
+     *
+     * Initialization is triggered asynchronously in this class' constructor, via:
+     *
+     * <pre>
+     * coroutineScope.launch(dispatcherProvider.io()) {
+     *     UrlPredictor.init()
+     * }
+     * </pre>
+     *
+     * Until initialization completes, calls to {@link #classify(String)} will fail
+     * if invoked directly on the underlying UrlPredictor instance; therefore,
+     * callers may use {@code isReady()} to determine whether classification is safe.
+     *
+     * This method does not block and is safe to call from any thread.
+     *
+     * @return {@code true} if the UrlPredictor native library has been loaded and
+     *         the predictor instance is fully initialized; {@code false} otherwise.
+     *
+     * @see UrlPredictor#isInitialized()
+     * @see UrlPredictor#init()
+     */
+    fun isReady(): Boolean
+
     /**
      * Classifies the input string as a navigable URL or a search query.
+     * You should be calling [isReady] before calling this method to make sure the library is properly initialized
      */
     fun classify(input: String): Decision
 }
@@ -34,6 +69,22 @@ interface QueryUrlPredictor {
  * Wrapper around the native implementation of [UrlPredictor] to allow unit testing.
  */
 @ContributesBinding(scope = AppScope::class)
-class QueryUrlPredictorImpl @Inject constructor() : QueryUrlPredictor {
-    override fun classify(input: String): Decision = UrlPredictor.classify(input)
+@SingleInstanceIn(scope = AppScope::class)
+class QueryUrlPredictorImpl @Inject constructor(
+    @AppCoroutineScope coroutineScope: CoroutineScope,
+    dispatcherProvider: DispatcherProvider,
+) : QueryUrlPredictor {
+
+    init {
+        coroutineScope.launch(dispatcherProvider.io()) {
+            UrlPredictor.init()
+            logcat { "UrlPredictor library initialized" }
+        }
+    }
+
+    override fun isReady(): Boolean {
+        return UrlPredictor.isInitialized()
+    }
+
+    override fun classify(input: String): Decision = UrlPredictor.get().classify(input)
 }

app/src/test/java/com/duckduckgo/app/browser/QueryUrlConverterTest.kt

@@ -77,6 +77,7 @@ class QueryUrlConverterTest {
     fun setup() {
         whenever(variantManager.getVariantKey()).thenReturn("")
         whenever(duckChat.isEnabled()).thenReturn(true)
+        whenever(queryUrlPredictor.isReady()).thenReturn(true)
         androidBrowserConfigFeature.hideDuckAiInSerpKillSwitch().setRawStoredState(State(true))
     }
 
@@ -455,6 +456,20 @@ class QueryUrlConverterTest {
         verify(queryUrlPredictor).classify("foo")
     }
 
+    @Test
+    fun `when url predictor is not ready and config enabled then url predictor not used`() {
+        val testee = createTestee(useUrlPredictorEnabled = false)
+        whenever(queryUrlPredictor.classify("foo")).thenReturn(Decision.Search("foo"))
+        whenever(queryUrlPredictor.isReady()).thenReturn(false)
+        androidBrowserConfigFeature.useUrlPredictor().setRawStoredState(State(true))
+        testee.onPrivacyConfigDownloaded()
+        val input = "foo"
+        val expected = "foo"
+        val result = testee.convertQueryToUrl(input, queryOrigin = QueryOrigin.FromUser, extractUrlFromQuery = false)
+        assertDuckDuckGoSearchQuery(expected, result)
+        verify(queryUrlPredictor, never()).classify("foo")
+    }
+
     @Test
     fun `when url predictor enabled and extract url enabled but not url then search returned`() {
         val testee = createTestee(useUrlPredictorEnabled = true)

versions.properties

@@ -86,7 +86,7 @@ version.com.duckduckgo.netguard..netguard-android=1.10.2
 
 version.com.duckduckgo.synccrypto..sync-crypto-android=0.7.0
 
-version.com.duckduckgo.urlpredictor..url-predictor-android=0.3.4
+version.com.duckduckgo.urlpredictor..url-predictor-android=0.3.10
 
 version.com.frybits.harmony..harmony=1.2.6