Skip to content

Commit d15b95b

Browse files
authored
Fix: Toolbar navigation button not centered (#7008)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211720464454564?focus=true ### Description This PR centers the navigation button vertically in all toolbars across the app. ### Steps to test this PR _Top omnibar position_ - [x] Go to the tab manager - [x] Verify the back button is centered vertically _Bottom omnibar position_ - [x] Go to the tab manager - [x] Verify the back button is centered vertically _Other screens_ - [x] Go to Settings - [x] Verify the back button is centered vertically - [x] Try opening other settings screens - [x] Verify the back button is centered vertically ### UI changes | Top tab manager | Bottom tab manager | Other screens | | ------ | ----- | ----- | <img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/1e9f5560-ae10-495b-a336-e4a25dd1faf4" />|<img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/b5fa451f-eb16-419c-b6f0-f52e5d1ecb51" />|<img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/fe75e437-0136-460c-aea5-7c7c4f9ae405" />
1 parent e5c47d9 commit d15b95b

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

design-system/src/main/res/layout/include_default_toolbar.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
android:layout_height="?attr/actionBarSize"
3232
android:background="?attr/daxColorToolbar"
3333
android:theme="@style/Widget.DuckDuckGo.ToolbarTheme"
34+
app:buttonGravity="center_vertical"
3435
app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" />
3536

3637
<View

design-system/src/main/res/layout/include_tab_switcher_toolbar_bottom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
android:layout_height="?attr/actionBarSize"
3737
android:background="?attr/daxColorToolbar"
3838
android:theme="@style/TabSwitcher.Widget.Toolbar"
39+
app:buttonGravity="center_vertical"
3940
app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" />
4041

4142
</com.google.android.material.appbar.AppBarLayout>

design-system/src/main/res/layout/include_tab_switcher_toolbar_top.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
android:layout_height="?attr/actionBarSize"
3232
android:background="?attr/daxColorToolbar"
3333
android:theme="@style/TabSwitcher.Widget.Toolbar"
34+
app:buttonGravity="center_vertical"
3435
app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" />
3536

3637
<View

0 commit comments

Comments
 (0)