Skip to content

Commit 475d99c

Browse files
authored
Fix complex script runtime issues (#7142)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211981173033273?focus=true ### Description A last minute seemingly innocent refactor in [βœ“ πŸ‘©β€πŸ’» Create artificially complex script](https://app.asana.com/1/137249556945/task/1211793818697003) is causing Uncaught ReferenceError: Cannot access 'stateManager' before initialization , which prevents the script from fully executing ### Steps to test this PR _Feature 1_ - [ ] Set `const val PRIVACY_REMOTE_CONFIG_URL = "https://api.jsonblob.com/019a97b1-c9a7-768f-8cad-bc5c8f4f6f7e"` - [ ] Fresh install - [ ] Load a site - [ ] Open Chrome console and check logs for - [ ] `Posting initial ping...` - [ ] `Performance measures: ` - [ ] `Messaging feature initialized` - [ ] `ddgBlobDownloadObj received Pong from Native` - [ ] `Performance feature initialized` - [ ] `window received ...` ### UI changes n/a
1 parent b210b63 commit 475d99c

File tree

1 file changed

+3
-19
lines changed

1 file changed

+3
-19
lines changed

β€Žapp/src/main/res/raw/webviewcompat_complex_test_script.jsβ€Ž

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -27,38 +27,22 @@
2727
// Listen to ddgObj messages
2828
ddgObj.addEventListener('message', function(event) {
2929
console.log("[complex script] $OBJECT_NAME$-$SCRIPT_ID$ received", event.data);
30-
31-
stateManager.setState(state => ({
32-
...state,
33-
messageCount: state.messageCount + 1,
34-
lastMessageTime: Date.now()
35-
}));
36-
37-
eventBus.emit('message-received', { source: '$OBJECT_NAME$-$SCRIPT_ID$', data: event.data });
38-
30+
3931
if (replyToNativeMessages && supportedMessages.includes(event.data)) {
4032
const response = messagePrefix + event.data + " from $OBJECT_NAME$-$SCRIPT_ID$";
4133
ddgObj.postMessage(response);
42-
throttledLog('[complex-script]-$SCRIPT_ID$ Sent response:', response);
34+
console.log('[complex-script]-$SCRIPT_ID$ Sent response:', response);
4335
}
4436
});
4537

4638
// Listen to window messages
4739
window.addEventListener('message', function(event) {
4840
console.log("[complex-script] window-$SCRIPT_ID$ received", event.data);
4941

50-
stateManager.setState(state => ({
51-
...state,
52-
messageCount: state.messageCount + 1,
53-
lastMessageTime: Date.now()
54-
}));
55-
56-
eventBus.emit('message-received', { source: 'window-$SCRIPT_ID$', data: event.data });
57-
5842
if (replyToNativeMessages && supportedMessages.includes(event.data)) {
5943
const response = messagePrefix + event.data + " from window-$SCRIPT_ID$";
6044
ddgObj.postMessage(response);
61-
throttledLog('[complex-script]-$SCRIPT_ID$ Sent response:', response);
45+
console.log('[complex-script]-$SCRIPT_ID$ Sent response:', response);
6246
}
6347
});
6448

0 commit comments

Comments
Β (0)