Commit 0941155
authored
Split Omnibar: Omnibar layout refactoring (#6983)
Task/Issue URL:
https://app.asana.com/1/137249556945/project/1207418217763355/task/1211565479656354
### Description
This PR refactors the `OmnibarLayout` and `SingleOmnibarLayout`.
`OmnibarLayout` was renamed to `LegacyOmnibarLayout` and a new
`OmnibarLayout` is a unified, merged version of `OmnibarLayout` and
`SingleOmnibarLayout`.
Thew new omnibar is guarded by a `useUnifiedOmnibarLayout` feature flag.
To make that work, an `OminbarView` interface needed to be extracted,
which is now used within the `Omnibar` class. Depending on the flag
value, either the old `LegacyOmnibarLayout ` or the new `OmnibarLayout`
is used. The feature flag is enabled by default.
Also, some of the interfaces from `OmnibarLayout` had to be extracted
(`StateChange`, `Decoration`) to avoid duplication.
### Steps to test this PR
_FF enabled_
- [x] Verify that onboarding highlighting works
- [x] Verify all buttons work
- [x] Verify tab swiping works
- [x] Verify tracker animations work
- [x] Verify the cookies animations work
- [x] Verify that omnibar hiding on scroll works
_FF disabled_
- [x] Disable the `useUnifiedOmnibarLayout` FF in the internal settings
- [x] Verify that onboarding highlighting works
- [x] Verify all buttons work
- [x] Verify tab swiping works
- [x] Verify tracker animations work
- [x] Verify the cookies animations work
- [x] Verify that omnibar hiding on scroll works1 parent d15b95b commit 0941155
File tree
18 files changed
+2031
-217
lines changed- app/src
- main
- java/com/duckduckgo/app
- browser
- omnibar
- animations/addressbar
- model
- webview
- pixels/remoteconfig
- res
- layout
- values
- test/java/com/duckduckgo/app/browser/omnibar
18 files changed
+2031
-217
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
767 | 767 | | |
768 | 768 | | |
769 | 769 | | |
770 | | - | |
| 770 | + | |
771 | 771 | | |
772 | 772 | | |
773 | 773 | | |
| |||
868 | 868 | | |
869 | 869 | | |
870 | 870 | | |
871 | | - | |
| 871 | + | |
872 | 872 | | |
873 | 873 | | |
874 | 874 | | |
| |||
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
146 | 149 | | |
| 150 | + | |
147 | 151 | | |
148 | 152 | | |
149 | 153 | | |
| |||
1012 | 1016 | | |
1013 | 1017 | | |
1014 | 1018 | | |
1015 | | - | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
1016 | 1024 | | |
1017 | 1025 | | |
1018 | 1026 | | |
| |||
1100 | 1108 | | |
1101 | 1109 | | |
1102 | 1110 | | |
1103 | | - | |
| 1111 | + | |
1104 | 1112 | | |
1105 | 1113 | | |
1106 | 1114 | | |
| |||
2952 | 2960 | | |
2953 | 2961 | | |
2954 | 2962 | | |
2955 | | - | |
| 2963 | + | |
2956 | 2964 | | |
2957 | 2965 | | |
2958 | 2966 | | |
| |||
2983 | 2991 | | |
2984 | 2992 | | |
2985 | 2993 | | |
2986 | | - | |
| 2994 | + | |
2987 | 2995 | | |
2988 | 2996 | | |
2989 | 2997 | | |
| |||
3025 | 3033 | | |
3026 | 3034 | | |
3027 | 3035 | | |
| 3036 | + | |
| 3037 | + | |
| 3038 | + | |
| 3039 | + | |
3028 | 3040 | | |
3029 | 3041 | | |
3030 | 3042 | | |
| |||
3038 | 3050 | | |
3039 | 3051 | | |
3040 | 3052 | | |
3041 | | - | |
| 3053 | + | |
3042 | 3054 | | |
3043 | 3055 | | |
3044 | 3056 | | |
| |||
0 commit comments