const and let all variables

Author: dubzzz

src/arbitrary/command.js

@@ -2,7 +2,7 @@
 const jsc = require('jsverify');
 const lazyseq = require("lazy-seq");
 
-var arbNullTuple = function(arbsArray) {
+const arbNullTuple = function(arbsArray) {
     if (arbsArray.length === 0) {
         return jsc.bless({
             generator: size => [],
@@ -13,9 +13,9 @@ var arbNullTuple = function(arbsArray) {
     return jsc.tuple(arbsArray);
 };
 
-var arbCommand = function(TypeName, ...arbs) {
-    var arbParameters = arbNullTuple(arbs);
-    var build = function(parameters) {
+const arbCommand = function(TypeName, ...arbs) {
+    const arbParameters = arbNullTuple(arbs);
+    const build = function(parameters) {
         return {
             command: new TypeName(...parameters),
             parameters: parameters,

src/arbitrary/commands.js

@@ -2,32 +2,22 @@
 const jsc = require('jsverify');
 const lazyseq = require("lazy-seq");
 
-var cloneObject = function(o) {
-    var cloned = {};
+const cloneObject = function(o) {
+    const cloned = {};
     Object.keys(o).filter(v => v != "hasStarted").forEach(k => cloned[k] = o[k]);
     return cloned;
 };
 
-
-
-var jscCommandsArray = function(gen, maxSize) {
-    /**
-     * jsc.array uses logsize function as a limiter of its size...
-     * 
-     * // Helper, essentially: log2(size + 1)
-     * function logsize(size) {
-     *   return Math.max(Math.round(Math.log(size + 1) / Math.log(2), 0));
-     * }
-     */
-    var shrinkImpl = function(arr) {
+const jscCommandsArray = function(gen, maxSize) {
+    const shrinkImpl = function(arr) {
         if (arr.length === 0) {
             return lazyseq.nil;
         }
 
-        var x = arr[0];
-        var xs = arr.slice(1);
+        const x = arr[0];
+        const xs = arr.slice(1);
 
-        var cuts = [];
+        const cuts = [];
         for (let start = Math.floor(xs.length/2) ; start !== 0 ; start = Math.floor(start/2)) {
             cuts.push(start);
         }
@@ -39,12 +29,8 @@ var jscCommandsArray = function(gen, maxSize) {
     };
     return jsc.bless({
         generator: (size) => {
-            var arrsize = jsc.random(0, maxSize);
-            var arr = new Array(arrsize);
-            for (var i = 0; i < arrsize; i++) {
-                arr[i] = gen.generator(size);
-            }
-            return arr;
+            const arrsize = jsc.random(0, maxSize);
+            return [...new Array(arrsize).keys()].map(() => gen.generator(size));
         },
         shrink: (arr) => {
             for (let idx = 0 ; idx != arr.length ; ++idx) {
@@ -59,7 +45,7 @@ var jscCommandsArray = function(gen, maxSize) {
     });
 };
 
-var arbCommands = function(...commands) {
+const arbCommands = function(...commands) {
     return typeof(commands[0]) === 'number'
         ? jscCommandsArray(jsc.oneof(...commands.slice(1)), commands[0])
         : jscCommandsArray(jsc.oneof(...commands), 100);

src/runner/forall.js

@@ -2,18 +2,18 @@
 const jsc = require('jsverify');
 const {runner} = require('./runner');
 
-var forallImpl = function(arbSeed, arbCommands, warmup, teardown) {
+const forallImpl = function(arbSeed, arbCommands, warmup, teardown) {
     return jsc.forall(arbSeed, arbCommands, runner(warmup, teardown));
 };
 
-var DEFAULT_SEED_GEN = jsc.constant(undefined);
-var DEFAULT_WARMUP = seed => new Object({state: {}, model: {}});
-var DEFAULT_TEARDOWN = () => {};
+const DEFAULT_SEED_GEN = jsc.constant(undefined);
+const DEFAULT_WARMUP = seed => new Object({state: {}, model: {}});
+const DEFAULT_TEARDOWN = () => {};
 
-var isGenerator = function(obj) {
+const isGenerator = function(obj) {
     return obj !== undefined && obj.generator !== undefined;
 };
-var forall = function(...params) {
+const forall = function(...params) {
     if (params.length === 0 || ! isGenerator(params[0])) {
         throw "forall requires at least a commands generator as first argument";
     }

src/runner/runner.js

@@ -1,8 +1,8 @@
 "use strict";
 
-var runall = async function(commands, state, model) {
-    for (var idx = 0 ; idx != commands.length ; ++idx) {
-        var cm = commands[idx];
+const runall = async function(commands, state, model) {
+    for (let idx = 0 ; idx != commands.length ; ++idx) {
+        const cm = commands[idx];
         if (cm.command.check(model)) {
             cm.hasStarted = true;
             try {
@@ -15,10 +15,10 @@ var runall = async function(commands, state, model) {
     return true;
 };
 
-var runner = function(warmup, teardown) {
+const runner = function(warmup, teardown) {
     return async function(seed, commands) {
-        var {state, model} = await warmup(seed);
-        var result = await runall(commands, state, model);
+        const {state, model} = await warmup(seed);
+        const result = await runall(commands, state, model);
         await teardown(state, model);
         return result;
     };