Merge pull request #39 from dtcooper/bugfix/null-accumulation

pR0Ps · web-flow · commit fe4ca694e02f · 2017-10-13T15:09:58.000-04:00
Only accumulate non-null values
diff --git a/fitparse/base.py b/fitparse/base.py
@@ -334,7 +334,7 @@ def _parse_data_message(self, header):
                         cmp_raw_value = component.render(raw_value)
 
                         # Apply accumulated value
-                        if component.accumulate:
+                        if component.accumulate and cmp_raw_value is not None:
                             accumulator = self._accumulators[def_mesg.mesg_num]
                             cmp_raw_value = self._apply_compressed_accumulation(
                                 cmp_raw_value, accumulator[component.def_num], component.bits,
diff --git a/tests/files/null_compressed_speed_dist.fit b/tests/files/null_compressed_speed_dist.fit
diff --git a/tests/test.py b/tests/test.py
@@ -376,7 +376,7 @@ def test_valid_files(self):
                   'antfs-dump.63.fit', 'sample-activity-indoor-trainer.fit',
                   'sample-activity.fit', 'garmin-fenix-5-bike.fit',
                   'garmin-fenix-5-run.fit', 'garmin-fenix-5-walk.fit',
-                  'garmin-edge-820-bike.fit'):
+                  'garmin-edge-820-bike.fit', 'null_compressed_speed_dist.fit'):
             FitFile(testfile(x)).parse()
 
     def test_units_processor(self):
