-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Main Objective: replace all use cases of glamorous and glamor to use emotion object styles
Purpose:
- Unify styling under pattern
- Scope styles to components
- Implement object based syntax rather than template literal approach
Several different implementations currently exist for styling components, however each finished implementation should follow the same pattern. Here are two patterns that could be followed for final implementation:
- Example of variable
cssimplementation: copyright atom - Example of inline
cssimplementation: talk molecule
Examples of implementations that need to be changed over to emotion:
- Example
glamordependence`: navigation atom - Example
glamorousdependence: sponsor bar atom
Recommendations:
- Use storybook to confirm styling doesn't change from before to after your fix implementation
- Changing one file per commit per PR
- Use
git czcommit type offixso there is a version bump associated with a successfully merged PR (if you need help setting upcommitizenvisit this link)
Feel free to reach out with questions or bring the conversation to the DSM Web Collective Slack
- migrate
styleprop usage - migrate direct usage of
glamor - migrate
glamouroususage - remove packages
Metadata
Metadata
Assignees
Labels
No labels