Skip to content

Update styles to use emotion #571

@micleners

Description

@micleners

Main Objective: replace all use cases of glamorous and glamor to use emotion object styles

Purpose:

  • Unify styling under pattern
  • Scope styles to components
  • Implement object based syntax rather than template literal approach

Several different implementations currently exist for styling components, however each finished implementation should follow the same pattern. Here are two patterns that could be followed for final implementation:

Examples of implementations that need to be changed over to emotion:

Recommendations:

  • Use storybook to confirm styling doesn't change from before to after your fix implementation
  • Changing one file per commit per PR
  • Use git cz commit type of fix so there is a version bump associated with a successfully merged PR (if you need help setting up commitizen visit this link)

Feel free to reach out with questions or bring the conversation to the DSM Web Collective Slack

  • migrate style prop usage
  • migrate direct usage of glamor
  • migrate glamourous usage
  • remove packages

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions