WIP ProjectOptions: retire the publishToRemote attribute

It's been made obsolete by the removal of the CLI.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/patch-series.ts

@@ -1,7 +1,7 @@
 /* eslint-disable security/detect-unsafe-regex */
 import addressparser from "nodemailer/lib/addressparser/index.js";
 import mimeFuncs from "nodemailer/lib/mime-funcs/index.js";
-import { commitExists, git, gitConfig, gitShortHash, revListCount, revParse } from "./git.js";
+import { commitExists, git, gitShortHash, revListCount, revParse } from "./git.js";
 import { GitNotes } from "./git-notes.js";
 import { IGitGitGadgetOptions } from "./gitgitgadget.js";
 import { IMailMetadata } from "./mail-metadata.js";
@@ -138,9 +138,7 @@ export class PatchSeries {
             throw new Error(`Cannot find base branch ${basedOn}`);
         }
 
-        const publishToRemote: string | undefined = undefined;
-
-        const project = await ProjectOptions.get(config, workDir, headCommit, cc, baseCommit, basedOn, publishToRemote);
+        const project = await ProjectOptions.get(config, workDir, headCommit, cc, baseCommit, basedOn);
         if (rangeDiff) {
             options.rangeDiff = rangeDiff;
         }
@@ -639,7 +637,7 @@ export class PatchSeries {
         this.metadata.coverLetterMessageId = coverMid;
 
         logger.log("Generating tag message");
-        let tagMessage = PatchSeries.generateTagMessage(
+        const tagMessage = PatchSeries.generateTagMessage(
             mails[0],
             mails.length > 1,
             this.project.midUrlPrefix,
@@ -657,16 +655,6 @@ export class PatchSeries {
 
         this.metadata.latestTag = tagName;
 
-        if (this.project.publishToRemote) {
-            const url = await gitConfig(`remote.${this.project.publishToRemote}.url`, this.project.workDir);
-            if (!url) {
-                throw new Error(`remote ${this.project.publishToRemote} lacks URL`);
-            }
-
-            logger.log("Inserting links");
-            tagMessage = PatchSeries.insertLinks(tagMessage, url, tagName, this.project.basedOn);
-        }
-
         if (this.options.noUpdate) {
             logger.log(
                 `Would generate tag ${tagName} with message:\n\n ${tagMessage

lib/project-options.ts

@@ -9,7 +9,6 @@ export class ProjectOptions {
         cc: string[],
         baseCommit: string,
         basedOn?: string,
-        publishToRemote?: string,
     ): Promise<ProjectOptions> {
         const to = `--to=${config.project.to}`;
         const midUrlPrefix = config.project.urlPrefix;
@@ -25,13 +24,12 @@ export class ProjectOptions {
             cc.push("Johannes Sixt <j6t@kdbg.org>");
         }
 
-        return new ProjectOptions(branchName, basedOn, publishToRemote, to, cc, midUrlPrefix, workDir, baseCommit);
+        return new ProjectOptions(branchName, basedOn, to, cc, midUrlPrefix, workDir, baseCommit);
     }
 
     public readonly branchName: string;
     public readonly baseCommit: string;
     public readonly basedOn?: string;
-    public readonly publishToRemote?: string;
     public readonly workDir: string;
 
     public readonly to: string;
@@ -41,7 +39,6 @@ export class ProjectOptions {
     protected constructor(
         branchName: string,
         basedOn: string | undefined,
-        publishToRemote: string | undefined,
         to: string,
         cc: string[],
         midUrlPrefix: string,
@@ -53,7 +50,6 @@ export class ProjectOptions {
         this.baseCommit = baseCommit;
 
         this.basedOn = basedOn;
-        this.publishToRemote = publishToRemote;
         this.workDir = workDir;
 
         this.to = to;

tests/patch-series.test.ts

@@ -95,7 +95,7 @@ class PatchSeriesTest extends PatchSeries {
         };
         class ProjectOptionsTest extends ProjectOptions {
             public constructor() {
-                super("", "", "", "", [], "", "", "");
+                super("", "", "", [], "", "", "");
             }
         }
 

tests/project-options.test.ts

@@ -29,7 +29,6 @@ test("project options", async () => {
         ["Nguyễn Thái Ngọc Duy <pclouds@gmail.com>"],
         "test-project-options^",
         undefined,
-        undefined,
     );
     expect(options2.workDir).not.toBeUndefined();
     expect(options2.midUrlPrefix).toEqual("https://dummy.com/?mid=");