Merge pull request ActiveState#3664 from ActiveState/mitchell/dx-3229

Remove `state init` language inference.

Author: mitchell-as

internal/locale/locales/en-us.yaml

@@ -876,7 +876,7 @@ deploy_uninstall_success:
 err_arg_required:
   other: "The following argument is required:\n  Name: [NOTICE]{{.V0}}[/RESET]\n  Description: [NOTICE]{{.V1}}[/RESET]"
 err_init_no_language:
-  other: "A project has not been set using 'state use'. You must include the [NOTICE]language[/RESET] argument. For more help, run '[ACTIONABLE]state init --help[/RESET]'."
+  other: "You must include the [NOTICE]language[/RESET] argument. For more help, run '[ACTIONABLE]state init --help[/RESET]'."
 platform_added:
   other: "[NOTICE]{{.V0}}[/RESET] has been added."
 platform_removed:

internal/runners/initialize/init.go

@@ -96,34 +96,6 @@ func New(prime primeable) *Initialize {
 	return &Initialize{prime, prime.Auth(), prime.Config(), prime.Output(), prime.Analytics(), prime.SvcModel()}
 }
 
-// inferLanguage tries to infer a reasonable default language from the project currently in use
-// (i.e. `state use show`).
-// Error handling is not necessary because it's an input error to not include a language to
-// `state init`. We're just trying to infer one as a convenience to the user.
-func inferLanguage(config projectfile.ConfigGetter, auth *authentication.Auth) (string, string, bool) {
-	defaultProjectDir := config.GetString(constants.GlobalDefaultPrefname)
-	if defaultProjectDir == "" {
-		return "", "", false
-	}
-	defaultProj, err := project.FromPath(defaultProjectDir)
-	if err != nil {
-		return "", "", false
-	}
-	commitID, err := localcommit.Get(defaultProj.Dir())
-	if err != nil {
-		multilog.Error("Unable to get local commit: %v", errs.JoinMessage(err))
-		return "", "", false
-	}
-	if commitID == "" {
-		return "", "", false
-	}
-	lang, err := model.FetchLanguageForCommit(commitID, auth)
-	if err != nil {
-		return "", "", false
-	}
-	return lang.Name, lang.Version, true
-}
-
 func (r *Initialize) Run(params *RunParams) (rerr error) {
 	defer func() { runtime_runbit.RationalizeSolveError(r.prime.Project(), r.auth, &rerr) }()
 
@@ -181,10 +153,6 @@ func (r *Initialize) Run(params *RunParams) (rerr error) {
 			languageVersion = langParts[1]
 		}
 	} else {
-		languageName, languageVersion, _ = inferLanguage(r.config, r.auth)
-	}
-
-	if languageName == "" {
 		return errNoLanguage
 	}
 

test/integration/init_int_test.go

@@ -114,33 +114,6 @@ func (suite *InitIntegrationTestSuite) TestInit_NoLanguage() {
 	ts.IgnoreLogErrors()
 }
 
-func (suite *InitIntegrationTestSuite) TestInit_InferLanguageFromUse() {
-	suite.OnlyRunForTags(tagsuite.Init)
-	ts := e2e.New(suite.T(), false)
-	defer ts.Close()
-	ts.LoginAsPersistentUser()
-
-	cp := ts.Spawn("config", "set", constants.AsyncRuntimeConfig, "true")
-	cp.ExpectExitCode(0)
-
-	cp = ts.Spawn("checkout", "ActiveState-CLI/small-python")
-	cp.Expect("Checked out project")
-	cp.ExpectExitCode(0)
-
-	cp = ts.Spawn("use", "small-python")
-	cp.Expect("Switched to project", e2e.RuntimeSourcingTimeoutOpt)
-	cp.ExpectExitCode(0)
-
-	pname := strutils.UUID()
-	namespace := fmt.Sprintf("%s/%s", e2e.PersistentUsername, pname)
-	cp = ts.Spawn("init", namespace)
-	cp.Expect("successfully initialized")
-	cp.ExpectExitCode(0)
-	ts.NotifyProjectCreated(e2e.PersistentUsername, pname.String())
-
-	suite.Contains(string(fileutils.ReadFileUnsafe(filepath.Join(ts.Dirs.Work, constants.ConfigFileName))), "language: python3")
-}
-
 func (suite *InitIntegrationTestSuite) TestInit_NotAuthenticated() {
 	suite.OnlyRunForTags(tagsuite.Init)
 	ts := e2e.New(suite.T(), false)