-
Notifications
You must be signed in to change notification settings - Fork 200
lukas/update margin calc to match onchain #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LukasDeco
wants to merge
13
commits into
master
Choose a base branch
from
lukas/update-margin-calc-to-match-onchain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Nov 3, 2025
crispheaney
reviewed
Nov 3, 2025
crispheaney
reviewed
Nov 3, 2025
crispheaney
reviewed
Nov 3, 2025
crispheaney
reviewed
Nov 3, 2025
crispheaney
reviewed
Nov 3, 2025
Collaborator
Author
|
@crispheaney does the |
Member
|
calculateFreeCollateralDeltaForPerp doesnt have to change since it doesnt look at deposits at all |
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 10, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
crispheaney
reviewed
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK’s margin calculation logic to:
Previously, the SDK would loop through user perp and spot positions multiple times, doing a lot of redundant work. With the new methods added, this PR refactors those flows so that margin is computed in a single, cleaner pass — reducing duplication and making the results better match the on-chain behavior. Through the new
User.getMarginCalculationmethod, this is the central logic for calculating collateral and margin requirement. Now methods likeUser.getFreeCollateralcall this function internally.Commits: