Skip to content

fix: span duration property has inconsistent time formats #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: span duration property has inconsistent time formats #245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4291e8
fix
Dec 1, 2025
cd6e777
fix
Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dreadnode/tracing/span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,10 @@ def duration(self) -> float:
"""Get the duration of the span in seconds."""
if self._span is None:
return 0.0
end_time = self.end_time or time.time()
return (end_time - self.start_time) if self.start_time else 0.0
end_time = self.end_time or time.time_ns()
if not self.start_time:
return 0.0
return (end_time - self.start_time) / 1e9

def set_tags(self, tags: t.Sequence[str]) -> None:
tags = [tags] if isinstance(tags, str) else list(tags)
Expand Down
Loading