Merge pull request #159 from dreadnode/users/raja/fix-pre-commit-errors

fix: Fix Ruff, MyPy, and PyTest Errors

Author: rdheekonda

.hooks/generate_docs.py

@@ -96,7 +96,7 @@ def simple_convert_markdown(
             html_id: str = "",
             **kwargs: t.Any,
         ) -> t.Any:
-            return Markup(md.convert(text) if text else "")  # noqa: S704 # nosec
+            return Markup(md.convert(text) if text else "")  # nosec  # noqa: S704
 
         self.handler.env.filters["convert_markdown"] = simple_convert_markdown
 

dreadnode/__init__.py

@@ -32,7 +32,7 @@
 from dreadnode.version import VERSION
 
 if t.TYPE_CHECKING:
-    from dreadnode import scorers  # noqa: F401
+    from dreadnode import scorers
 
 logger.disable("dreadnode")
 

dreadnode/agent/agent.py

@@ -51,6 +51,8 @@
 from dreadnode.agent.stop import StopCondition, stop_never
 from dreadnode.agent.thread import Thread
 from dreadnode.agent.tools import AnyTool, Tool, Toolset, discover_tools_on_obj
+from dreadnode.agent.tools.planning import update_todo
+from dreadnode.agent.tools.tasking import finish_task, give_up_on_task
 from dreadnode.agent.types import Message, ToolCall
 from dreadnode.meta import Component, Config, Model, component
 from dreadnode.scorers import ScorersLike
@@ -745,9 +747,6 @@ class TaskAgent(Agent):
     """
 
     def model_post_init(self, _: t.Any) -> None:
-        from dreadnode.agent.tools.planning import update_todo
-        from dreadnode.agent.tools.tasking import finish_task, give_up_on_task
-
         if not any(tool for tool in self.tools if tool.name == "finish_task"):
             self.tools.append(finish_task)
 

dreadnode/agent/console.py

@@ -48,13 +48,13 @@ def _handle_tool_start(self, event: ToolStart) -> None:
                 self._status_table, console=self.console, transient=True, auto_refresh=True
             )
             self._live_status.start()
+        if self._status_table is not None:
+            # Add a new row for the running tool with a spinner.
+            self._status_table.add_row(
+                Text(f"Running [bold]{event.tool_call.name}[/bold]...", style="yellow")
+            )
 
-        # Add a new row for the running tool with a spinner.
-        self._status_table.add_row(
-            Text(f"Running [bold]{event.tool_call.name}[/bold]...", style="yellow")
-        )
-
-    def _handle_tool_end(self, event: ToolEnd):
+    def _handle_tool_end(self, event: ToolEnd) -> None:
         """Prints the tool's result and cleans up the status board."""
         # First, print the static result panel. This ensures it's in the
         # console history even after the live display is gone.

dreadnode/agent/hooks/summarize.py

@@ -1,6 +1,8 @@
 import contextlib
 import typing as t
 
+from litellm.exceptions import ContextWindowExceededError
+
 from dreadnode.agent.events import AgentError, AgentEvent, GenerationEnd, StepStart
 from dreadnode.agent.prompts import summarize_conversation
 from dreadnode.agent.reactions import Continue, Reaction, Retry
@@ -23,8 +25,6 @@
 def _is_context_length_error(error: BaseException) -> bool:
     """Checks if an exception is likely due to exceeding the context window."""
     with contextlib.suppress(ImportError):
-        from litellm.exceptions import ContextWindowExceededError
-
         if isinstance(error, ContextWindowExceededError):
             return True
 

dreadnode/agent/tools/fs.py

@@ -8,7 +8,7 @@
 import rigging as rg
 from fsspec import AbstractFileSystem  # type: ignore[import-untyped]
 from pydantic import PrivateAttr
-from upath import UPath
+from upath import UPath  # type: ignore[import-not-found]
 
 from dreadnode.agent.tools import Toolset, tool_method
 from dreadnode.meta import Config
@@ -127,7 +127,7 @@ def read_file(
         content = _path.read_bytes()
 
         try:
-            return content.decode("utf-8")
+            return content.decode("utf-8")  # type: ignore[no-any-return]
         except UnicodeDecodeError as e:
             if self.multi_modal:
                 return rg.ContentImageUrl.from_file(path)

dreadnode/agent/tools/tasking.py

@@ -5,7 +5,7 @@
 
 
 @tool
-async def finish_task(success: bool, summary: str) -> None:  # noqa: ARG001, FBT001
+async def finish_task(success: bool, summary: str) -> None:  # noqa: ARG001
     """
     Mark your task as complete with a success/failure status and markdown summary of actions taken.
 

dreadnode/airt/attack/prompt.py

@@ -28,7 +28,7 @@ def prompt_attack(
     beam_width: int = 3,
     branching_factor: int = 3,
     max_steps: int = 10,
-    additional_scorers: list[Scorer] | None = None,
+    additional_scorers: list[Scorer[t.Any]] | None = None,
     name: str | None = None,
 ) -> Attack[str, str]:
     """
@@ -88,7 +88,7 @@ def prompt_attack(
 
     objective = weighted_avg(
         (judge_scorer, 1),
-        *[(scorer, 1) for scorer in additional_scorers],
+        *[(scorer, 1) for scorer in (additional_scorers or [])],
         name="prompt_objective",
     )
 

dreadnode/airt/attack/tap.py

@@ -18,7 +18,7 @@ def tap_attack(
     beam_width: int = 10,
     branching_factor: int = 3,
     max_steps: int = 10,
-    additional_constraints: list[Scorer] | None = None,
+    additional_constraints: list[Scorer[t.Any]] | None = None,
 ) -> Attack[str, str]:
     """
     Creates a Generative Attack optimized for the TAP (Tree-of-thought Attack Prompting) pattern,

dreadnode/airt/target/llm.py

@@ -35,6 +35,8 @@ class LLMTarget(Model, Target[t.Any, str]):
 
     @property
     def name(self) -> str:
+        if self._generator is None:
+            return "unknown"
         return self._generator.to_identifier(short=True)
 
     def as_task(self, input: t.Any) -> Task[[], str]:
@@ -51,9 +53,12 @@ def as_task(self, input: t.Any) -> Task[[], str]:
 
         @task(name=f"generate - {self.name}", label="llm_target_generate", tags=["target"])
         async def generate(
-            messages: list[rg.Message] = messages, params: rg.GenerateParams = params
+            messages: list[rg.Message] = messages, params: rg.GenerateParams | None = params
         ) -> str:
-            generated = (await self._generator.generate_messages([messages], [params]))[0]
+            if self._generator is None:
+                raise ValueError("Generator not initialized")
+            params_list = [params] if params is not None else [rg.GenerateParams()]
+            generated = (await self._generator.generate_messages([messages], params_list))[0]
             if isinstance(generated, BaseException):
                 raise generated
             return generated.message.content