Skip to content

Commit 10c6ae9

Browse files
committed
Fix mypy errors
1 parent ec0aa88 commit 10c6ae9

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

dreadnode/credential_manager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from typing import TYPE_CHECKING, TypeVar
55

66
from botocore.exceptions import ClientError
7-
from s3fs import S3FileSystem
7+
from s3fs import S3FileSystem # type: ignore[import-untyped]
88

99
from dreadnode.constants import FS_CREDENTIAL_REFRESH_BUFFER
1010
from dreadnode.util import logger, resolve_endpoint
@@ -29,7 +29,7 @@ def __init__(self, credential_fetcher: Callable[[], "UserDataCredentials"]):
2929
self._credential_fetcher = credential_fetcher
3030
self._credentials: UserDataCredentials | None = None
3131
self._credentials_expiry: datetime | None = None
32-
self._filesystem = None
32+
self._filesystem: S3FileSystem | None = None
3333
self._prefix = ""
3434

3535
def initialize(self) -> None:
@@ -40,6 +40,7 @@ def get_filesystem(self) -> S3FileSystem:
4040
"""Get current filesystem, refreshing credentials if needed."""
4141
if self._needs_refresh():
4242
self._refresh_credentials()
43+
assert self._filesystem is not None # noqa: S101
4344
return self._filesystem
4445

4546
def get_prefix(self) -> str:

dreadnode/main.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,15 @@ def initialize(self) -> None:
347347
# )
348348
# )
349349
# )
350-
self._credential_manager = CredentialManager(
351-
credential_fetcher=lambda: self._api.get_user_data_credentials()
352-
)
353-
self._credential_manager.initialize()
350+
if self._api is not None:
351+
api = self._api
352+
self._credential_manager = CredentialManager(
353+
credential_fetcher=lambda: api.get_user_data_credentials()
354+
)
355+
self._credential_manager.initialize()
354356

355-
self._fs = self._credential_manager.get_filesystem()
356-
self._fs_prefix = self._credential_manager.get_prefix()
357+
self._fs = self._credential_manager.get_filesystem()
358+
self._fs_prefix = self._credential_manager.get_prefix()
357359

358360
self._logfire = logfire.configure(
359361
local=not self.is_default,

0 commit comments

Comments
 (0)