Disable keepDOM in tabs and collapses (#335)

1ilit · web-flow · commit 40ef1ca91ba0 · 2025-01-18T22:26:42.000+04:00
diff --git a/src/components/EditorSidePanel/Issues.jsx b/src/components/EditorSidePanel/Issues.jsx
@@ -32,7 +32,7 @@ export default function Issues() {
   }, [tables, relationships, issues, types, database, enums]);
 
   return (
-    <Collapse keepDOM lazyRender style={{ width: "100%" }}>
+    <Collapse lazyRender keepDOM={false} style={{ width: "100%" }}>
       <Collapse.Panel
         header={
           <Badge
diff --git a/src/components/EditorSidePanel/NotesTab/NotesTab.jsx b/src/components/EditorSidePanel/NotesTab/NotesTab.jsx
@@ -33,7 +33,7 @@ export default function NotesTab() {
       ) : (
         <Collapse
           activeKey={selectedElement.open ? `${selectedElement.id}` : ""}
-          keepDOM
+          keepDOM={false}
           lazyRender
           onChange={(activeKey) => {
             setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx b/src/components/EditorSidePanel/RelationshipsTab/RelationshipsTab.jsx
@@ -27,7 +27,7 @@ export default function RelationshipsTab() {
               ? `${selectedElement.id}`
               : ""
           }
-          keepDOM
+          keepDOM={false}
           lazyRender
           onChange={(k) =>
             setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/SidePanel.jsx b/src/components/EditorSidePanel/SidePanel.jsx
@@ -62,6 +62,7 @@ export default function SidePanel({ width, resize, setResize }) {
             type="card"
             activeKey={selectedElement.currentTab}
             lazyRender
+            keepDOM={false}
             onChange={(key) =>
               setSelectedElement((prev) => ({ ...prev, currentTab: key }))
             }
diff --git a/src/components/EditorSidePanel/TablesTab/TableInfo.jsx b/src/components/EditorSidePanel/TablesTab/TableInfo.jsx
@@ -160,7 +160,7 @@ export default function TableInfo({ data }) {
         >
           <Collapse
             activeKey={indexActiveKey}
-            keepDOM
+            keepDOM={false}
             lazyRender
             onChange={(itemKey) => setIndexActiveKey(itemKey)}
             accordion
@@ -187,7 +187,7 @@ export default function TableInfo({ data }) {
         style={{ marginTop: "12px", marginBottom: "12px" }}
         headerLine={false}
       >
-        <Collapse keepDOM lazyRender>
+        <Collapse keepDOM={false} lazyRender>
           <Collapse.Panel header={t("comment")} itemKey="1">
             <TextArea
               field="comment"
diff --git a/src/components/EditorSidePanel/TablesTab/TablesTab.jsx b/src/components/EditorSidePanel/TablesTab/TablesTab.jsx
@@ -31,7 +31,7 @@ export default function TablesTab() {
               ? `${selectedElement.id}`
               : ""
           }
-          keepDOM
+          keepDOM={false}
           lazyRender
           onChange={(k) =>
             setSelectedElement((prev) => ({
diff --git a/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx b/src/components/EditorSidePanel/TypesTab/TypeInfo.jsx
@@ -89,7 +89,7 @@ export default function TypeInfo({ index, data }) {
           style={{ marginTop: "12px", marginBottom: "12px" }}
           headerLine={false}
         >
-          <Collapse keepDOM lazyRender>
+          <Collapse lazyRender keepDOM={false}>
             <Collapse.Panel header={t("comment")} itemKey="1">
               <TextArea
                 field="comment"
diff --git a/src/components/EditorSidePanel/TypesTab/TypesTab.jsx b/src/components/EditorSidePanel/TypesTab/TypesTab.jsx
@@ -49,7 +49,7 @@ export default function TypesTab() {
               ? `${selectedElement.id}`
               : ""
           }
-          keepDOM
+          keepDOM={false}
           lazyRender
           onChange={(id) =>
             setSelectedElement((prev) => ({

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export default function RelationshipsTab() {`
`27`	`27`	? `${selectedElement.id}`
`28`	`28`	`: ""`
`29`	`29`	`}`
`30`		`- keepDOM`
	`30`	`+ keepDOM={false}`
`31`	`31`	`lazyRender`
`32`	`32`	`onChange={(k) =>`
`33`	`33`	`setSelectedElement((prev) => ({`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ export default function SidePanel({ width, resize, setResize }) {`
`62`	`62`	`type="card"`
`63`	`63`	`activeKey={selectedElement.currentTab}`
`64`	`64`	`lazyRender`
	`65`	`+ keepDOM={false}`
`65`	`66`	`onChange={(key) =>`
`66`	`67`	`setSelectedElement((prev) => ({ ...prev, currentTab: key }))`
`67`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export default function TablesTab() {`
`31`	`31`	? `${selectedElement.id}`
`32`	`32`	`: ""`
`33`	`33`	`}`
`34`		`- keepDOM`
	`34`	`+ keepDOM={false}`
`35`	`35`	`lazyRender`
`36`	`36`	`onChange={(k) =>`
`37`	`37`	`setSelectedElement((prev) => ({`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ export default function TypeInfo({ index, data }) {`
`89`	`89`	`style={{ marginTop: "12px", marginBottom: "12px" }}`
`90`	`90`	`headerLine={false}`
`91`	`91`	`>`
`92`		`- <Collapse keepDOM lazyRender>`
	`92`	`+ <Collapse lazyRender keepDOM={false}>`
`93`	`93`	`<Collapse.Panel header={t("comment")} itemKey="1">`
`94`	`94`	`<TextArea`
`95`	`95`	`field="comment"`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export default function TypesTab() {`
`49`	`49`	? `${selectedElement.id}`
`50`	`50`	`: ""`
`51`	`51`	`}`
`52`		`- keepDOM`
	`52`	`+ keepDOM={false}`
`53`	`53`	`lazyRender`
`54`	`54`	`onChange={(id) =>`
`55`	`55`	`setSelectedElement((prev) => ({`