use mergeBlockData of Modifier instead of adding new one in utils

Author: freedomlang

examples/checkable-list-example/src/CheckableList.js

@@ -6,10 +6,10 @@ import {
   ContentBlock,
   DefaultDraftBlockRenderMap,
   RichUtils,
+  Modifier,
 } from 'draft-js'
 import { withPluginContext } from '@djsp/core'
 import type { PluginProps } from '@djsp/core'
-import { mergeBlockData } from '@djsp/utils'
 import {
   CheckableListItem,
   CheckableListItemBlock,
@@ -20,31 +20,34 @@ import {
 class CheckableList extends Component<PluginProps> {
   _unregister: () => void
 
-  updateEditorState = (newEditorState: EditorState) => {
-    const { setEditorState, editorState } = this.props
-    setEditorState(
-      EditorState.forceSelection(newEditorState, editorState.getSelection())
-    )
-  }
-
   onClick = event => {
     event.stopPropagation()
 
-    const { editorState } = this.props
+    const { setEditorState, editorState } = this.props
     const newEditorState = RichUtils.toggleBlockType(
       editorState,
       CHECKABLE_LIST_ITEM
     )
-    this.updateEditorState(newEditorState)
+    setEditorState(
+      EditorState.forceSelection(newEditorState, editorState.getSelection())
+    )
   }
 
   toggleChecked = (block: ContentBlock) => {
-    const { editorState } = this.props
-
-    let newEditorState = mergeBlockData(editorState, block, {
-      checked: !block.getData().get('checked'),
-    })
-    this.updateEditorState(newEditorState)
+    const { setEditorState, editorState } = this.props
+    let newContentState = Modifier.mergeBlockData(
+      editorState.getCurrentContent(),
+      editorState.getSelection(),
+      {
+        checked: !block.getData().get('checked'),
+      }
+    )
+    let newEditorState = EditorState.push(
+      editorState,
+      newContentState,
+      'change-block-data'
+    )
+    setEditorState(newEditorState)
   }
 
   componentDidMount() {

packages/utils/README.md

@@ -149,12 +149,6 @@ getWordCount(editorState: EditorState): number
 mergeEntityData(editorState: EditorState, entityKey: string, data: Object): EditorState
 ```
 
-### mergeBlockData
-
-```javascript
-mergeBlockData(editorState: EditorState, block: ContentBlock, data: { [id: string]: any }): EditorState
-```
-
 ## License
 
 MIT © [juliankrispel](https://github.com/juliankrispel)

packages/utils/src/index.js

@@ -278,19 +278,3 @@ export function mergeEntityData(
 
   return EditorState.push(editorState, newContentState, 'apply-entity')
 }
-
-export function mergeBlockData(
-  editorState: EditorState,
-  block: ContentBlock,
-  data: { [id: string]: any }
-): EditorState {
-  const content = editorState.getCurrentContent()
-  const updatedBlock = block.mergeIn(['data'], data)
-  const blockKey = block.getKey()
-  const blockMap = content.getBlockMap().merge({ [blockKey]: updatedBlock })
-  return EditorState.push(
-    editorState,
-    content.merge({ blockMap }),
-    'change-block-data'
-  )
-}