Copy the keys from framework session state (#559)

It appears that some session providers on the framework side may not be able to iterate over the keys while grabbing items as it may throw an InvalidOperationException with the error: Collection was modified after the enumerator was instantiated. Even though it appears that this should not happen, we'll copy the keys over before grabbing items from the collection so this can't happen.

Author: twsouthwick

src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/SessionState/Serialization/HttpSessionStateBaseWrapper.cs

@@ -54,7 +54,17 @@ public bool IsAbandoned
         }
     }
 
-    public IEnumerable<string> Keys => State.Keys.Cast<string>();
+    public IEnumerable<string> Keys
+    {
+        get
+        {
+            // If the underlying storage mechanism is SessionStateItemCollection then there can be issues around the enumerator causing side effects.
+            // There are precautions in the implementation to prevent this, but we have seen an exception around this in practice (see dotnet/systemweb-adapters#556).
+            // However, there is no simple way to check if this is the case, so we'll preemptively create a copy.
+            // See https://referencesource.microsoft.com/#System.Web/State/SessionStateItemCollection.cs,435 for the warnings in the implementation.
+            return [.. State.Keys.Cast<string>()];
+        }
+    }
 
     public void Clear() => State.Clear();