Handle relative referer headers similar to ASP.NET Framework (#547)

Author: twsouthwick

src/Microsoft.AspNetCore.SystemWebAdapters/HttpRequest.cs

@@ -196,7 +196,13 @@ public bool IsLocal
 
         public string ApplicationPath => Request.HttpContext.RequestServices.GetRequiredService<IOptions<SystemWebAdaptersOptions>>().Value.AppDomainAppVirtualPath;
 
-        public Uri? UrlReferrer => TypedHeaders.Referer;
+        // ASP.NET Framework would assume a relative referer is relative to the current app
+        public Uri? UrlReferrer => TypedHeaders.Referer switch
+        {
+            { IsAbsoluteUri: true } abs => abs,
+            { } relative => new Uri(Url, relative),
+            null => null,
+        };
 
         public int TotalBytes => (int)InputStream.Length;
 

test/Microsoft.AspNetCore.SystemWebAdapters.Tests/HttpRequestTests.cs

@@ -12,6 +12,7 @@
 using System.Web;
 using AutoFixture;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Extensions;
 using Microsoft.AspNetCore.Http.Features;
 using Microsoft.AspNetCore.SystemWebAdapters.Features;
 using Microsoft.AspNetCore.SystemWebAdapters.Internal;
@@ -535,10 +536,52 @@ public void UrlReferrer()
             // Act
             var result = request.UrlReferrer;
 
-            // AssertexpectedResult
+            // Assert
             Assert.Equal(new Uri(referrer), result);
         }
 
+        [Fact]
+        public void UrlRelativeReferrer()
+        {
+            // Arrange
+            var referrer = "/some-relative-url";
+            var headers = new HeaderDictionary
+            {
+                { HeaderNames.Referer, referrer },
+            };
+
+            var coreRequest = new Mock<HttpRequestCore>();
+            coreRequest.Setup(c => c.Scheme).Returns("https");
+            coreRequest.Setup(c => c.Host).Returns(new HostString("microsoft.com"));
+            coreRequest.Setup(c => c.Headers).Returns(headers);
+
+            var request = new HttpRequest(coreRequest.Object);
+
+            // Act
+            var result = request.UrlReferrer;
+
+            // Assert
+            Assert.NotNull(result);
+            Assert.True(result.IsAbsoluteUri);
+            Assert.Equal(new Uri("https://microsoft.com/some-relative-url"), result);
+        }
+
+        [Fact]
+        public void NoReferer()
+        {
+            // Arrange
+            var coreRequest = new Mock<HttpRequestCore>();
+            coreRequest.Setup(c => c.Headers).Returns(new HeaderDictionary());
+
+            var request = new HttpRequest(coreRequest.Object);
+
+            // Act
+            var result = request.UrlReferrer;
+
+            // Assert
+            Assert.Null(result);
+        }
+
         [Fact]
         public void TotalBytes()
         {