Fix GitVariableName hashing

Author: tmat

src/Microsoft.Build.Tasks.Git/GitDataReader/GitVariableName.cs

@@ -3,54 +3,43 @@
 // See the License.txt file in the project root for more information.
 
 using System;
-using System.Diagnostics;
 
-namespace Microsoft.Build.Tasks.Git
+namespace Microsoft.Build.Tasks.Git;
+
+internal readonly struct GitVariableName(string sectionName, string subsectionName, string variableName) : IEquatable<GitVariableName>
 {
-    internal readonly struct GitVariableName : IEquatable<GitVariableName>
-    {
-        public static readonly StringComparer SectionNameComparer = StringComparer.OrdinalIgnoreCase;
-        public static readonly StringComparer SubsectionNameComparer = StringComparer.Ordinal;
-        public static readonly StringComparer VariableNameComparer = StringComparer.OrdinalIgnoreCase;
-
-        public readonly string SectionName;
-        public readonly string SubsectionName;
-        public readonly string VariableName;
-
-        public GitVariableName(string sectionName, string subsectionName, string variableName)
-        {
-            NullableDebug.Assert(sectionName != null);
-            NullableDebug.Assert(subsectionName != null);
-            NullableDebug.Assert(variableName != null);
-
-            SectionName = sectionName;
-            SubsectionName = subsectionName;
-            VariableName = variableName;
-        }
-
-        public bool SectionNameEquals(string name)
-            => SectionNameComparer.Equals(SectionName, name);
-
-        public bool SubsectionNameEquals(string name)
-            => SubsectionNameComparer.Equals(SubsectionName, name);
-
-        public bool VariableNameEquals(string name)
-            => VariableNameComparer.Equals(VariableName, name);
-
-        public bool Equals(GitVariableName other)
-            => SectionNameEquals(other.SectionName) &&
-               SubsectionNameEquals(other.SubsectionName) &&
-               VariableNameEquals(other.VariableName);
-
-        public override bool Equals(object? obj)
-            => obj is GitVariableName other && Equals(other);
-
-        public override int GetHashCode()
-            => SectionName.GetHashCode() ^ SubsectionName.GetHashCode() ^ VariableName.GetHashCode();
-
-        public override string ToString()
-            => (SubsectionName.Length == 0) ?
-                SectionName + "." + VariableName :
-                SectionName + "." + SubsectionName + "." + VariableName;
-    }
+    public static readonly StringComparer SectionNameComparer = StringComparer.OrdinalIgnoreCase;
+    public static readonly StringComparer SubsectionNameComparer = StringComparer.Ordinal;
+    public static readonly StringComparer VariableNameComparer = StringComparer.OrdinalIgnoreCase;
+
+    public readonly string SectionName = sectionName;
+    public readonly string SubsectionName = subsectionName;
+    public readonly string VariableName = variableName;
+
+    public bool SectionNameEquals(string name)
+        => SectionNameComparer.Equals(SectionName, name);
+
+    public bool SubsectionNameEquals(string name)
+        => SubsectionNameComparer.Equals(SubsectionName, name);
+
+    public bool VariableNameEquals(string name)
+        => VariableNameComparer.Equals(VariableName, name);
+
+    public bool Equals(GitVariableName other)
+        => SectionNameEquals(other.SectionName) &&
+           SubsectionNameEquals(other.SubsectionName) &&
+           VariableNameEquals(other.VariableName);
+
+    public override bool Equals(object? obj)
+        => obj is GitVariableName other && Equals(other);
+
+    public override int GetHashCode()
+        => SectionNameComparer.GetHashCode(SectionName) ^
+           SubsectionNameComparer.GetHashCode(SubsectionName) ^
+           VariableNameComparer.GetHashCode(VariableName);
+
+    public override string ToString()
+        => (SubsectionName.Length == 0) ?
+            SectionName + "." + VariableName :
+            SectionName + "." + SubsectionName + "." + VariableName;
 }