Skip to content

Commit b5bfe0c

Browse files
committed
overlay format's msbuild
1 parent 9e279b8 commit b5bfe0c

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

src/Layout/redist/targets/GenerateLayout.targets

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,27 @@
117117
<DotnetFormatConfigFiles Include="$(Pkgdotnet-format)/tools/net8.0/any/**/*.config" />
118118
</ItemGroup>
119119

120+
<!-- SDK Microsoft.Build assemblies to overlay for version consistency -->
121+
<ItemGroup>
122+
<SdkMicrosoftBuildFiles Include="$(OutputPath)/Microsoft.Build.dll" />
123+
<SdkMicrosoftBuildFiles Include="$(OutputPath)/Microsoft.Build.Framework.dll" />
124+
<SdkMicrosoftBuildFiles Include="$(OutputPath)/Microsoft.Build.Tasks.Core.dll" />
125+
<SdkMicrosoftBuildFiles Include="$(OutputPath)/Microsoft.Build.Utilities.Core.dll" />
126+
</ItemGroup>
127+
120128
<Error Condition="'@(DotnetFormatDllFiles)' == ''" Text="Something moved around in dotnet-format package, adjust code here accordingly. TFM change?" />
121129
<Error Condition="'@(DotnetFormatConfigFiles)' == ''" Text="Something moved around in dotnet-format package, adjust code here accordingly. TFM change?" />
130+
131+
<!-- Copy dotnet-format files first -->
122132
<Copy SourceFiles="@(DotnetFormatDllFiles)" DestinationFiles="@(DotnetFormatDllFiles->'$(DotnetFormatDestinationDirectory)/%(RecursiveDir)%(Filename)%(Extension)')" />
123133
<Copy SourceFiles="@(DotnetFormatConfigFiles)" DestinationFiles="@(DotnetFormatConfigFiles->'$(DotnetFormatDestinationDirectory)/%(RecursiveDir)%(Filename)%(Extension)')" />
134+
135+
<!-- Overlay newer Microsoft.Build.* assemblies from SDK for version consistency
136+
this does not fix deps.json inconsistencies but ensures we don't ship vulnerable packages -->
137+
<Copy SourceFiles="@(SdkMicrosoftBuildFiles)"
138+
DestinationFolder="$(DotnetFormatDestinationDirectory)"
139+
Condition="Exists('%(FullPath)')"
140+
OverwriteReadOnlyFiles="true" />
124141
</Target>
125142

126143
<Target Name="PublishMSBuildExtensions"

0 commit comments

Comments
 (0)