[release/10.0.1xx-preview7] Avoid double disposal of terminal logger (#49970)

github-actions[bot] · jjonescz · web-flow · commit a9ebb58cf11d · 2025-07-28T19:46:40.000+02:00
Co-authored-by: Jan Jones &lt;janjones@microsoft.com&gt;
diff --git a/src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs b/src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs
@@ -273,6 +273,7 @@ public override int Execute()
             }
 
             BuildManager.DefaultBuildManager.EndBuild();
+            consoleLogger = null; // avoid double disposal which would throw
 
             return 0;
         }
@@ -289,7 +290,7 @@ public override int Execute()
             }
 
             binaryLogger?.Value.ReallyShutdown();
-            consoleLogger.Shutdown();
+            consoleLogger?.Shutdown();
         }
 
         static Action<IDictionary<string, string>> AddRestoreGlobalProperties(ReadOnlyDictionary<string, string>? restoreProperties)

Original file line number	Diff line number	Diff line change
`@@ -273,6 +273,7 @@ public override int Execute()`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`BuildManager.DefaultBuildManager.EndBuild();`
	`276`	`+ consoleLogger = null; // avoid double disposal which would throw`
`276`	`277`
`277`	`278`	`return 0;`
`278`	`279`	`}`
`@@ -289,7 +290,7 @@ public override int Execute()`
`289`	`290`	`}`
`290`	`291`
`291`	`292`	`binaryLogger?.Value.ReallyShutdown();`
`292`		`- consoleLogger.Shutdown();`
	`293`	`+ consoleLogger?.Shutdown();`
`293`	`294`	`}`
`294`	`295`
`295`	`296`	`static Action<IDictionary<string, string>> AddRestoreGlobalProperties(ReadOnlyDictionary<string, string>? restoreProperties)`